build-sys: mark systemd-firstboot man page as conditional

[elogind.git] / CODING_STYLE

diff --git a/CODING_STYLE b/CODING_STYLE
index 4439ee6099abb707a4114a8b32b7e94608a75cea..30d24e56a6e1fa4ec9e40896f47096451b629f7b 100644 (file)
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -1,4 +1,5 @@
-- 8ch indent, no tabs
+- 8ch indent, no tabs, except for files in man/ which are 2ch indent,
+  and still no tabs
 
 - Don't break code lines too eagerly. We do *not* force line breaks at
   80ch, all of today's screens should be much larger than that. But
@@ -190,3 +191,8 @@
 - Do not write functions that clobber call-by-reference variables on
   failure. Use temporary variables for these cases and change the
   passed in variables only on success.
+
+- When you allocate a file descriptor, it should be made O_CLOEXEC
+  right from the beginning, as none of our files should leak to forked
+  binaries by default. Hence, whenever you open a file, O_CLOEXEC must
+  be specified, right from the beginning.