cg_path_get_user_unit(): Did not correctly parse user-unit templates.

[elogind.git] / CODING_STYLE

diff --git a/CODING_STYLE b/CODING_STYLE
index 4439ee6099abb707a4114a8b32b7e94608a75cea..0b1f809e79717812c0fdd007e1ef5786a5f4e916 100644 (file)
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -190,3 +190,8 @@
 - Do not write functions that clobber call-by-reference variables on
   failure. Use temporary variables for these cases and change the
   passed in variables only on success.
 - Do not write functions that clobber call-by-reference variables on
   failure. Use temporary variables for these cases and change the
   passed in variables only on success.

+
+- When you allocate a file descriptor, it should be made O_CLOEXEC
+  right from the beginning, as none of our files should leak to forked
+  binaries by default. Hence, whenever you open a file, O_CLOEXEC must
+  be specified, right from the beginning.