From 0929e8c0d79bd140a1a3d459042045c0d4a2b011 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Thu, 3 Aug 2017 12:48:05 +0100 Subject: [PATCH] dgit: Properly shellquote --git-builder argument to gbp This is about to contain more exciting shell metacharacters. (Even now, it is wrong without quoting as we end up telling gbp to pass -i.git/ rather than -i\.git/ to dpkg-source.) Signed-off-by: Ian Jackson --- debian/changelog | 1 + dgit | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index 81059b50..00cee5f9 100644 --- a/debian/changelog +++ b/debian/changelog @@ -9,6 +9,7 @@ dgit (4.1~) experimental; urgency=medium Other improvements to dgit: * New print-dpkg-source-ignores option to print the big rune you need to pass to dpkg-source to make it work exactly the right. + * Properly shell-quote the --git-builder argument to gbp. Documentation: * dgit-user(7): Provide information about how to use sbuild. diff --git a/dgit b/dgit index 3c94f036..9834d03b 100755 --- a/dgit +++ b/dgit @@ -6072,7 +6072,8 @@ sub cmd_gbp_build { } my @cmd = opts_opt_multi_cmd @gbp_build; - push @cmd, (qw(-us -uc --git-no-sign-tags), "--git-builder=@dbp"); + push @cmd, (qw(-us -uc --git-no-sign-tags), + "--git-builder=".(shellquote @dbp)); if ($gbp_make_orig) { my $priv = dgit_privdir(); -- 2.30.2