From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Thu, 12 Jul 2018 11:48:32 +0000 (+0100)
Subject: test suite: Use  dch -r -D sid ''  not  dch -r sid.
X-Git-Tag: archive/debian/5.9+exp1~4
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=dgit.git;a=commitdiff_plain;h=f11c6632af0949d0956149cfc2d4e51f18d468cc

test suite: Use  dch -r -D sid ''  not  dch -r sid.

Bizarrely,
   dch -r [-D suite]
runs $EDITOR but
   dch -r [-D suite] weevils
ignores `weevils' but does not run $EDITOR.  This is #903598.

Apparently, this is well known, and convention is to pass ''.
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=903598#8.

So use that.

Closes:#903441.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/debian/changelog b/debian/changelog
index 18a9cfe7..90b157c1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,6 @@
 dgit (5.9+exp1) experimental; urgency=medium
 
-  * 
+  * test suite: Use  dch -r -D sid ''  not  dch -r sid.  Closes:#903441.
 
  --
 
diff --git a/tests/lib b/tests/lib
index 04d1f2dc..e06ae224 100644
--- a/tests/lib
+++ b/tests/lib
@@ -1009,7 +1009,7 @@ t-commit () {
 t-dch-r-rune () {
 	local cmd="$1"; shift
 	local suite=${1-unstable}
-	$cmd -r sid
+	$cmd -r -D "$suite" ''
 }
 
 t-dch-commit-r () {