From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat, 11 Aug 2018 09:52:58 +0000 (+0100)
Subject: Dgit.pm: printdebug: Selectively print $debugprefix, and add a doc
X-Git-Tag: archive/debian/6.7~141
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=dgit.git;a=commitdiff_plain;h=3627acb401427824068b9d66011ee92aa16b3ad7

Dgit.pm: printdebug: Selectively print $debugprefix, and add a doc

Remember whether the last printdebug ended in a \n.  If it didn't,
suppress printing the next newline.

I don't think anywhere calls printdebug without @_ right now.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/Debian/Dgit.pm b/Debian/Dgit.pm
index 3d517e1e..34e40a3b 100644
--- a/Debian/Dgit.pm
+++ b/Debian/Dgit.pm
@@ -159,11 +159,21 @@ sub enabledebuglevel ($) {
 }
     
 sub printdebug {
+    # Prints a prefix, and @_, to DEBUG.  @_ should normally contain
+    # a trailing \n.
+
+    # With no (or only empty) arguments just prints the prefix and
+    # leaves the caller to do more with DEBUG.  The caller should make
+    # sure then to call printdebug with something ending in "\n" to
+    # get the prefix right in subsequent calls.
+
     return unless $debuglevel >= $printdebug_when_debuglevel;
-    print DEBUG $debugprefix;
+    our $printdebug_noprefix;
+    print DEBUG $debugprefix unless $printdebug_noprefix;
     pop @_ while @_ and !length $_[-1];
     return unless @_;
     print DEBUG @_ or die $!;
+    $printdebug_noprefix = $_[-1] !~ m{\n$};
 }
 
 sub messagequote ($) {