chiark / gitweb /
dgit: Properly shellquote --git-builder argument to gbp
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Thu, 3 Aug 2017 11:48:05 +0000 (12:48 +0100)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Fri, 4 Aug 2017 22:06:19 +0000 (23:06 +0100)
This is about to contain more exciting shell metacharacters.
(Even now, it is wrong without quoting as we end up telling gbp to
pass -i.git/ rather than -i\.git/ to dpkg-source.)

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
debian/changelog
dgit

index 81059b5..00cee5f 100644 (file)
@@ -9,6 +9,7 @@ dgit (4.1~) experimental; urgency=medium
   Other improvements to dgit:
   * New print-dpkg-source-ignores option to print the big rune
     you need to pass to dpkg-source to make it work exactly the right.
+  * Properly shell-quote the --git-builder argument to gbp.
 
   Documentation:
   * dgit-user(7): Provide information about how to use sbuild.
diff --git a/dgit b/dgit
index 3c94f03..9834d03 100755 (executable)
--- a/dgit
+++ b/dgit
@@ -6072,7 +6072,8 @@ sub cmd_gbp_build {
     }
     my @cmd = opts_opt_multi_cmd @gbp_build;
 
-    push @cmd, (qw(-us -uc --git-no-sign-tags), "--git-builder=@dbp");
+    push @cmd, (qw(-us -uc --git-no-sign-tags),
+               "--git-builder=".(shellquote @dbp));
 
     if ($gbp_make_orig) {
        my $priv = dgit_privdir();