X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=dgit.git;a=blobdiff_plain;f=i18n-diff-auditor;h=ce2034f600c64edc6716422f1058e12ca001946e;hp=80840913235bfe81230a885531651f0340e0a05b;hb=14074b0d336fcf80dc229ada4727345ec642222f;hpb=334750d1a92573ad4ed3817c60b15b20da0fa83b

diff --git a/i18n-diff-auditor b/i18n-diff-auditor
index 80840913..ce2034f6 100755
--- a/i18n-diff-auditor
+++ b/i18n-diff-auditor
@@ -108,7 +108,7 @@ our ($ichunkstart, $ichunkend);
 our ($before, $after);
 
 sub is_string ($) { $_[0]{T} =~ m/heredoc|string/; }
-sub is_trans ($) { grep { $_[0]{E} eq $_ } qw(__ f_); }
+sub is_trans ($) { grep { $_[0]{E} eq $_ } qw(__ f_ i_); }
 
 sub semiparse ($) {
     ($_) = @_;
@@ -144,9 +144,9 @@ sub semiparse ($) {
 		       Q => $q, V => $v};
 	} elsif (s{^$perlop_re|^\;}{}) {
 	    push @o, { T => 'op', E => $&, P => $& };
-	} elsif (s/[[{(]//) {
+	} elsif (s/^[[{(]//) {
 	    push @o, { T => 'bra', E => $&, P => $& };
-	} elsif (s/[]})]//) {
+	} elsif (s/^[]})]//) {
 	    push @o, { T => 'ket', E => $&, P => $& };
 	} elsif (s/^( [\$\@\%] )( \{ )//x) {
 	    push @o, { T => 'deref', E => $1, P => $1 },
@@ -160,9 +160,10 @@ sub semiparse ($) {
 	    die "cannot tokenise \`$&'";
 	}
     }
-    for (my $i=@o-2; $i>0; --$i) {
+    for (my $i=0; $i+2 < @o; $i++) {
 	next unless $o[$i+1]{E} eq '.';
 	my @inputs = @o[$i, $i+2];
+	#print STDERR Dumper(\@inputs);
 	next if grep { !is_string($_) } @inputs;
 	my $q = $inputs[0]{Q};
 	next if grep { $_->{Q} ne $q } @inputs;
@@ -173,6 +174,7 @@ sub semiparse ($) {
 		    Q => $q,
 		  };
 	@o = (@o[0..$i-1], $new, @o[$i+3..$#o]);
+	$i--; # counteracts $i++
     }
     debug $ichunkstart, "semiparsed: ".join ' ', map { $_->{P} } @o;
     return @o;
@@ -208,6 +210,8 @@ sub analyse_chunk_core () {
 	$next_x->();
 	$next_y->();
 	next if $x->{E} eq $y->{E};
+	next if $x->{E} eq 'sprintf' and $y->{E} eq 'f_';
+	next if $x->{E} eq 'die'     and $y->{E} eq 'confess';
 	if ($y->{E} eq '+'
 	    and @ys >= 3
 	    and $ys[0]{E} eq '('
@@ -221,7 +225,7 @@ sub analyse_chunk_core () {
 	if (is_trans($y)) {
 	    $next_y->();
 	    die "__ on non-string $y->{P}\n"     unless is_string($y);
-	    die "__ on was non-string $y->{P}\n" unless is_string($x);
+	    die "__ on was non-string $x->{P}\n" unless is_string($x);
 	    if ($y->{Q} ne "'") {
 		die "var subst in new string\n"
 		    if $y->{V} =~ m{(?<!\\) [\$\@]};
@@ -238,6 +242,10 @@ sub analyse_chunk_core () {
 	    die $string_changed if length $string_changed;
 	    next;
 	}
+	if ($ye eq 'i_') {
+	    die $string_changed if length $string_changed;
+	    next;
+	}
 	if ($ye eq 'f_') {
 	    my $fmt = $y->{V};
 	    die "no percent in _f string\n" unless $fmt =~ m{\%};
@@ -248,8 +256,8 @@ sub analyse_chunk_core () {
 		my ($lit, $what) = @_;
 		my $xl = substr($xs, 0, length($lit));
 		if ($xl ne $lit) {
-		    debug $ichunkstart, "not exactly x: ..\"$xs\"";
-		    debug $ichunkstart, "not exactly y:    $lit";
+		    debug $ichunkstart, "not exactly x: \"..$xs\"";
+		    debug $ichunkstart, "not exactly y:   $lit";
 		    my $next = @ys ? $ys[0]{P} : '(end)';
 		    die "string contents mismatch near $what before $next\n";
 		}
@@ -267,6 +275,15 @@ sub analyse_chunk_core () {
 		elsif ($& ne '%s') { die "unhandled %-subst $&\n"; }
 		$next_y->();
 		die "expected comma, got $y->{P}\n" unless $y->{E} eq ',';
+		if (!length $fmt and
+		    !length $xs and
+		    @xs and
+		    $xs[0]{E} eq '.') {
+		    # X has   "<earlier>" .                <something>
+		    # Y has   "<earlier>%s" [other args] , <something>
+		    $next_x->(); # eat the '.'
+		    next;
+		}
 		if ($xs =~ m{^\@}) {
 		    $next_y->();
 		    die "\@... => not string" unless is_string($y);
@@ -292,7 +309,11 @@ sub analyse_chunk_core () {
 			pop @analysed_y;
 			last;
 		    }
-		    $xs =~ s{^\s+}{};
+		    $xs =~ s{^\s+}{} if $bras;
+		    if (is_string($y) and $y->{Q} eq '"') {
+			$exactly->($y->{V}, $y->{P});
+			next;
+		    }
 		    $exactly->($y->{E}, $y->{P});
 		    if ($y->{T} eq 'bra' or $y->{E} eq '?') {
 			$bras++;