X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=dgit.git;a=blobdiff_plain;f=dgit;h=2ac6d51c6506af9980dc418c767e7cfe4fa0720c;hp=fe38f710bf4b6953b3f8b85631529b6119a12f41;hb=66b0259a66150cf67d5219400f8f89849c7d3c06;hpb=7c3fc6b786c71c2fdd6a72dcf896fa9ea38b24f9

diff --git a/dgit b/dgit
index fe38f710..2ac6d51c 100755
--- a/dgit
+++ b/dgit
@@ -4656,7 +4656,7 @@ END
     my $host = access_cfg('upload-host','RETURN-UNDEF');
     my @hostarg = defined($host) ? ($host,) : ();
     runcmd_ordryrun @dput, @hostarg, $changesfile;
-    printdone "pushed and uploaded $cversion";
+    printdone f_ "pushed and uploaded %s", $cversion;
 
     supplementary_message('');
     responder_send_command("complete");
@@ -4668,7 +4668,7 @@ sub pre_clone () {
 sub cmd_clone {
     parseopts();
     my $dstdir;
-    badusage "-p is not allowed with clone; specify as argument instead"
+    badusage __ "-p is not allowed with clone; specify as argument instead"
 	if defined $package;
     if (@ARGV==1) {
 	($package) = @ARGV;
@@ -4679,13 +4679,13 @@ sub cmd_clone {
     } elsif (@ARGV==3) {
 	($package,$isuite,$dstdir) = @ARGV;
     } else {
-	badusage "incorrect arguments to dgit clone";
+	badusage __ "incorrect arguments to dgit clone";
     }
     notpushing();
 
     $dstdir ||= "$package";
     if (stat_exists $dstdir) {
-	fail "$dstdir already exists";
+	fail f_ "%s already exists", $dstdir;
     }
 
     my $cwd_remove;
@@ -4695,15 +4695,16 @@ sub cmd_clone {
 	    return unless defined $cwd_remove;
 	    if (!chdir "$cwd_remove") {
 		return if $!==&ENOENT;
-		die "chdir $cwd_remove: $!";
+		confess "chdir $cwd_remove: $!";
 	    }
 	    printdebug "clone rmonerror removing $dstdir\n";
 	    if (stat $dstdir) {
-		rmtree($dstdir) or die "remove $dstdir: $!\n";
+		rmtree($dstdir) or fail f_ "remove %s: %s\n", $dstdir, $!;
 	    } elsif (grep { $! == $_ }
 		     (ENOENT, ENOTDIR, EACCES, EPERM, ELOOP)) {
 	    } else {
-		print STDERR "check whether to remove $dstdir: $!\n";
+		print STDERR f_ "check whether to remove %s: %s\n",
+		                $dstdir, $!;
 	    }
 	};
     }
@@ -4740,7 +4741,7 @@ sub fetchpullargs () {
     } elsif (@ARGV==1) {
 	($isuite) = @ARGV;
     } else {
-	badusage "incorrect arguments to dgit fetch or dgit pull";
+	badusage __ "incorrect arguments to dgit fetch or dgit pull";
     }
     notpushing();
 }
@@ -4756,8 +4757,8 @@ sub cmd_pull {
     fetchpullargs();
     if (quiltmode_splitbrain()) {
 	my ($format, $fopts) = get_source_format();
-	madformat($format) and fail <<END
-dgit pull not yet supported in split view mode (--quilt=$quilt_mode)
+	madformat($format) and fail f_ <<END, $quilt_mode
+dgit pull not yet supported in split view mode (--quilt=%s)
 END
     }
     pull();
@@ -4766,7 +4767,7 @@ END
 sub cmd_checkout {
     parseopts();
     package_from_d_control();
-    @ARGV==1 or badusage "dgit checkout needs a suite argument";
+    @ARGV==1 or badusage __ "dgit checkout needs a suite argument";
     ($isuite) = @ARGV;
     notpushing();
 
@@ -4828,17 +4829,17 @@ sub cmd_update_vcs_git () {
     my @cmd;
     my $orgurl = cfg 'remote.vcs-git.url', 'RETURN-UNDEF';
     if (!defined $orgurl) {
-	print STDERR "setting up vcs-git: $url\n";
+	print STDERR f_ "setting up vcs-git: %s\n", $url;
 	@cmd = (@git, qw(remote add vcs-git), $url);
     } elsif ($orgurl eq $url) {
-	print STDERR "vcs git already configured: $url\n";
+	print STDERR f_ "vcs git already configured: %s\n", $url;
     } else {
-	print STDERR "changing vcs-git url to: $url\n";
+	print STDERR f_ "changing vcs-git url to: %s\n", $url;
 	@cmd = (@git, qw(remote set-url vcs-git), $url);
     }
     runcmd_ordryrun_local @cmd;
     if ($dofetch) {
-	print "fetching (@ARGV)\n";
+	print f_ "fetching (%s)\n", "@ARGV";
 	runcmd_ordryrun_local @git, qw(fetch vcs-git), @ARGV;
     }
 }
@@ -4853,7 +4854,7 @@ sub prep_push () {
     } elsif (@ARGV==1) {
 	($specsuite) = (@ARGV);
     } else {
-	badusage "incorrect arguments to dgit $subcommand";
+	badusage f_ "incorrect arguments to dgit %s", $subcommand;
     }
     if ($new_package) {
 	local ($package) = $existing_package; # this is a hack
@@ -4864,8 +4865,9 @@ sub prep_push () {
     if (defined $specsuite &&
 	$specsuite ne $isuite &&
 	$specsuite ne $csuite) {
-	    fail "dgit $subcommand: changelog specifies $isuite ($csuite)".
-	        " but command line specifies $specsuite";
+	    fail f_ "dgit %s: changelog specifies %s (%s)".
+	            " but command line specifies %s",
+		    $subcommand, $isuite, $csuite, $specsuite;
     }
 }
 
@@ -4901,9 +4903,9 @@ sub pre_remote_push_build_host {
 	$vsnwant =~ m{^(?:.*,)?$_(?:,.*)?$}
     } @rpushprotovsn_support;
 
-    fail "build host has dgit rpush protocol versions ".
-	(join ",", @rpushprotovsn_support).
-        " but invocation host has $vsnwant"
+    fail f_ "build host has dgit rpush protocol versions %s".
+            " but invocation host has %s",
+	    (join ",", @rpushprotovsn_support), $vsnwant
 	unless defined $protovsn;
 
     changedir $dir;
@@ -4980,7 +4982,8 @@ sub cmd_rpush {
 
     if (defined $initiator_tempdir) {
 	rmtree $initiator_tempdir;
-	mkdir $initiator_tempdir, 0700 or die "$initiator_tempdir: $!";
+	mkdir $initiator_tempdir, 0700
+	    or fail f_ "create %s: %s", $initiator_tempdir, $!;
 	$i_tmp = $initiator_tempdir;
     } else {
 	$i_tmp = tempdir();
@@ -5017,10 +5020,10 @@ sub i_resp_complete {
     printdebug "waiting for build host child $pid...\n";
     my $got = waitpid $pid, 0;
     die $! unless $got == $pid;
-    die "build host child failed $?" if $?;
+    fail f_ "build host child failed: %s", waitstatusmsg() if $?;
 
     i_cleanup();
-    printdebug "all done\n";
+    printdebug __ "all done\n";
     finish 0;
 }
 
@@ -5029,7 +5032,7 @@ sub i_resp_file ($) {
     my $localname = i_method "i_localname", $keyword;
     my $localpath = "$i_tmp/$localname";
     stat_exists $localpath and
-	badproto \*RO, "file $keyword ($localpath) twice";
+	badproto \*RO, f_ "file %s (%s) twice", $keyword, $localpath;
     protocol_receive_file \*RO, $localpath;
     i_method "i_file", $keyword;
 }
@@ -5037,15 +5040,15 @@ sub i_resp_file ($) {
 our %i_param;
 
 sub i_resp_param ($) {
-    $_[0] =~ m/^(\S+) (.*)$/ or badproto \*RO, "bad param spec";
+    $_[0] =~ m/^(\S+) (.*)$/ or badproto \*RO, __ "bad param spec";
     $i_param{$1} = $2;
 }
 
 sub i_resp_previously ($) {
     $_[0] =~ m#^(refs/tags/\S+)=(\w+)$#
-	or badproto \*RO, "bad previously spec";
+	or badproto \*RO, __ "bad previously spec";
     my $r = system qw(git check-ref-format), $1;
-    die "bad previously ref spec ($r)" if $r;
+    confess "bad previously ref spec ($r)" if $r;
     $previously{$1} = $2;
 }
 
@@ -5062,8 +5065,9 @@ sub i_resp_want ($) {
     pushing();
     rpush_handle_protovsn_bothends();
 
-    fail "rpush negotiated protocol version $protovsn".
-	" which does not support quilt mode $quilt_mode"
+    fail f_ "rpush negotiated protocol version %s".
+	" which does not support quilt mode %s",
+	$protovsn, $quilt_mode
 	if quiltmode_splitbrain;
 
     my @localpaths = i_method "i_want", $keyword;
@@ -5106,10 +5110,10 @@ sub i_file_buildinfo {
     if (!forceing [qw(buildinfo-changes-mismatch)]) {
 	files_compare_inputs($bd, $ch);
 	(getfield $bd, $_) eq (getfield $ch, $_) or
-	    fail "buildinfo mismatch $_"
+	    fail f_ "buildinfo mismatch in field %s", $_
 	    foreach qw(Source Version);
 	!defined $bd->{$_} or
-	    fail "buildinfo contains $_"
+	    fail f_ "buildinfo contains forbidden field %s", $_
 	    foreach qw(Changes Changed-by Distribution);
     }
     push @i_buildinfos, $bi;
@@ -5150,7 +5154,7 @@ sub i_want_signed_tag {
 
     return
 	push_mktags $i_clogp, $i_dscfn,
-	    $i_changesfn, 'remote changes',
+	    $i_changesfn, (__ 'remote changes file'),
 	    \@tagwants;
 }
 
@@ -5176,7 +5180,7 @@ sub quiltify_dpkg_commit ($$$;$) {
 
     mkpath '.git/dgit'; # we are in playtree
     my $descfn = ".git/dgit/quilt-description.tmp";
-    open O, '>', $descfn or die "$descfn: $!";
+    open O, '>', $descfn or confess "$descfn: $!";
     $msg =~ s/\n+/\n\n/;
     print O <<END or die $!;
 From: $author
@@ -5225,21 +5229,21 @@ sub quiltify_trees_differ ($$;$$$) {
 
 	if ($unrepres) {
 	    eval {
-		die "not a plain file or symlink\n"
+		die __ "not a plain file or symlink\n"
 		    unless $newmode =~ m/^(?:10|12)\d{4}$/ ||
 		           $oldmode =~ m/^(?:10|12)\d{4}$/;
 		if ($oldmode =~ m/[^0]/ &&
 		    $newmode =~ m/[^0]/) {
 		    # both old and new files exist
-		    die "mode or type changed\n" if $oldmode ne $newmode;
-		    die "modified symlink\n" unless $newmode =~ m/^10/;
+		    die __ "mode or type changed\n" if $oldmode ne $newmode;
+		    die __ "modified symlink\n" unless $newmode =~ m/^10/;
 		} elsif ($oldmode =~ m/[^0]/) {
 		    # deletion
-		    die "deletion of symlink\n"
+		    die __ "deletion of symlink\n"
 			unless $oldmode =~ m/^10/;
 		} else {
 		    # creation
-		    die "creation with non-default mode\n"
+		    die __ "creation with non-default mode\n"
 			unless $newmode =~ m/^100644$/ or
 			       $newmode =~ m/^120000$/;
 		}
@@ -5269,7 +5273,7 @@ sub quiltify_tree_sentinelfiles ($) {
 
 sub quiltify_splitbrain_needed () {
     if (!$split_brain) {
-	progress "dgit view: changes are required...";
+	progress __ "dgit view: changes are required...";
 	runcmd @git, qw(checkout -q -b dgit-view);
 	$split_brain = 1;
     }
@@ -5298,32 +5302,34 @@ sub quiltify_splitbrain ($$$$$$$) {
 	my ($x,$y) = @_;
 	my $cmd = "git diff $x $y -- :/ ':!debian'";
 	$cmd .= " ':!/.gitignore' ':!*/.gitignore'" if $gitignore_special;
-	return "\nFor full diff showing the problem(s), type:\n $cmd\n";
+	return f_ "\nFor full diff showing the problem(s), type:\n %s\n",
+	          $cmd;
     };
 
     if ($quilt_mode =~ m/gbp|unapplied/ &&
 	($diffbits->{O2H} & 01)) {
-	my $msg =
- "--quilt=$quilt_mode specified, implying patches-unapplied git tree\n".
- " but git tree differs from orig in upstream files.";
+	my $msg = f_
+ "--quilt=%s specified, implying patches-unapplied git tree\n".
+ " but git tree differs from orig in upstream files.",
+                     $quilt_mode;
 	$msg .= $fulldiffhint->($unapplied, 'HEAD');
 	if (!stat_exists "debian/patches") {
-	    $msg .=
+	    $msg .= __
  "\n ... debian/patches is missing; perhaps this is a patch queue branch?";
 	}  
 	fail $msg;
     }
     if ($quilt_mode =~ m/dpm/ &&
 	($diffbits->{H2A} & 01)) {
-	fail <<END. $fulldiffhint->($oldtiptree,'HEAD');
---quilt=$quilt_mode specified, implying patches-applied git tree
+	fail +(f_ <<END, $quilt_mode). $fulldiffhint->($oldtiptree,'HEAD');
+--quilt=%s specified, implying patches-applied git tree
  but git tree differs from result of applying debian/patches to upstream
 END
     }
     if ($quilt_mode =~ m/gbp|unapplied/ &&
 	($diffbits->{O2A} & 01)) { # some patches
 	quiltify_splitbrain_needed();
-	progress "dgit view: creating patches-applied version using gbp pq";
+	progress __ "dgit view: creating patches-applied version using gbp pq";
 	runcmd shell_cmd 'exec >/dev/null', gbp_pq, qw(import);
 	# gbp pq import creates a fresh branch; push back to dgit-view
 	runcmd @git, qw(update-ref refs/heads/dgit-view HEAD);
@@ -5331,8 +5337,8 @@ END
     }
     if ($quilt_mode =~ m/gbp|dpm/ &&
 	($diffbits->{O2A} & 02)) {
-	fail <<END;
---quilt=$quilt_mode specified, implying that HEAD is for use with a
+	fail f_ <<END, $quilt_mode;
+--quilt=%s specified, implying that HEAD is for use with a
  tool which does not create patches for changes to upstream
  .gitignores: but, such patches exist in debian/patches.
 END
@@ -5340,23 +5346,27 @@ END
     if (($diffbits->{O2H} & 02) && # user has modified .gitignore
 	!($diffbits->{O2A} & 02)) { # patches do not change .gitignore
 	quiltify_splitbrain_needed();
-	progress "dgit view: creating patch to represent .gitignore changes";
+	progress __
+	    "dgit view: creating patch to represent .gitignore changes";
         ensuredir "debian/patches";
 	my $gipatch = "debian/patches/auto-gitignore";
-	open GIPATCH, ">>", "$gipatch" or die "$gipatch: $!";
-	stat GIPATCH or die "$gipatch: $!";
-	fail "$gipatch already exists; but want to create it".
-	    " to record .gitignore changes" if (stat _)[7];
-	print GIPATCH <<END or die "$gipatch: $!";
+	open GIPATCH, ">>", "$gipatch" or confess "$gipatch: $!";
+	stat GIPATCH or confess "$gipatch: $!";
+	fail f_ "%s already exists; but want to create it".
+	        " to record .gitignore changes",
+		$gipatch
+	    if (stat _)[7];
+	print GIPATCH <<END.<<ENDU or die "$gipatch: $!";
 Subject: Update .gitignore from Debian packaging branch
 
 The Debian packaging git branch contains these updates to the upstream
 .gitignore file(s).  This patch is autogenerated, to provide these
 updates to users of the official Debian archive view of the package.
+END
 
 [dgit ($our_version) update-gitignore]
 ---
-END
+ENDU
         close GIPATCH or die "$gipatch: $!";
         runcmd shell_cmd "exec >>$gipatch", @git, qw(diff),
             $unapplied, $headref, "--", sort keys %$editedignores;
@@ -5368,11 +5378,12 @@ END
 	print SERIES "auto-gitignore\n" or die $!;
 	close SERIES or die  $!;
         runcmd @git, qw(add -f -- debian/patches/series), $gipatch;
-        commit_admin <<END
+        commit_admin <<END.<<ENDU
 Commit patch to update .gitignore
+END
 
 [dgit ($our_version) update-gitignore-quilt-fixup]
-END
+ENDU
     }
 
     my $dgitview = git_rev_parse 'HEAD';
@@ -5508,19 +5519,14 @@ sub quiltify ($$$$) {
 	    $x =~ s/(.*?[0-9a-z]{8})[0-9a-z]*$/$1/;
 	    return $x;
 	};
-	my $reportnot = sub {
-	    my ($notp) = @_;
-	    my $s = $abbrev->($notp);
-	    my $c = $notp->{Child};
-	    $s .= "..".$abbrev->($c) if $c;
-	    $s .= ": ".$notp->{Whynot};
-	    return $s;
-	};
 	if ($quilt_mode eq 'linear') {
 	    print STDERR "\n$us: error: quilt fixup cannot be linear.  Stopped at:\n";
 	    my $all_gdr = !!@nots;
 	    foreach my $notp (@nots) {
-		print STDERR "$us:  ", $reportnot->($notp), "\n";
+		my $c = $notp->{Child};
+		my $cprange = $abbrev->($notp);
+		$cprange .= "..".$abbrev->($c) if $c;
+		print STDERR "$us:  $cprange: $notp->{Whynot}\n";
 		$all_gdr &&= $notp->{Child} &&
 		    (git_cat_file $notp->{Child}{Commit}, 'commit')
 		    =~ m{^\[git-debrebase(?! split[: ]).*\]$}m;
@@ -5589,7 +5595,7 @@ sub quiltify ($$$$) {
 		die "contains leading punctuation\n" if m{^\W} || m{/\W};
 		die "contains bad character(s)\n" if m{[^-a-z0-9_.+=~/]}i;
 		die "is series file\n" if m{$series_filename_re}o;
-		die "too long" if length > 200;
+		die "too long\n" if length > 200;
 	    };
 	    return $_ unless $@;
 	    print STDERR "quiltifying commit $cc:".
@@ -5757,11 +5763,12 @@ sub unpack_playtree_linkorigs ($$) {
 
 sub quilt_fixup_delete_pc () {
     runcmd @git, qw(rm -rqf .pc);
-    commit_admin <<END
+    commit_admin <<END.<<ENDU
 Commit removal of .pc (quilt series tracking data)
+END
 
 [dgit ($our_version) upgrade quilt-remove-pc]
-END
+ENDU
 }
 
 sub quilt_fixup_singlepatch ($$$) {