X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=dgit.git;a=blobdiff_plain;f=dgit-badcommit-fixup;h=8b202c0ae9617883d31239f6758843122cd2ff5c;hp=c119c4acae99f65f8e7e626b0a7960fb54bcb1fd;hb=1e05e9f8e94040b0a763cc9f88c77f83064ebc78;hpb=3894237fb0ac3d9c9d3857ae2dfd628d331c0f49

diff --git a/dgit-badcommit-fixup b/dgit-badcommit-fixup
index c119c4ac..8b202c0a 100755
--- a/dgit-badcommit-fixup
+++ b/dgit-badcommit-fixup
@@ -3,6 +3,7 @@
 # Script to help with fallout from #849041.
 #
 # usage:
+#   dgit-badcommit-fixup --check
 #   dgit-badcommit-fixup --test
 #   dgit-badcommit-fixup --real
 
@@ -34,6 +35,8 @@ foreach my $a (@ARGV) {
 	$real = 0;
     } elsif ($a eq '--real') {
 	$real = 1;
+    } elsif ($a eq '--check') {
+	$real = -1;
     } else {
 	die "$a ?";
     }
@@ -228,9 +231,20 @@ foreach my $rline (split /\n/, $refs) {
 	or die "$_ ?";
     if ($refname eq 'refs/dgit-rewrite/map') {
 	$org_rewrite_map = $obj;
-	continue;
+	next;
     }
     next if $refname =~ m{^refs/dgit-(?:badcommit|badfixuptest)/};
+
+    $!=0; $?=0;
+    system qw(sh -ec),
+	'exec >/dev/null git symbolic-ref -q "$1"', qw(x),
+	$refname;
+    if ($?==0) {
+	$count{symrefs_ignored}++;
+	next;
+    }
+    die "$? $!" unless $?==256;
+
     my $rewrite;
     if ($type eq 'commit') {
 	$rewrite = rewrite_commit($obj);
@@ -254,40 +268,48 @@ if ($bare eq 'true') {
 filter_updates();
 
 if (!@updates) {
-    print Dumper(\%count), "nothing to do\n";
+    print Dumper(\%count), "all is well - nothing to do\n";
     exit 0;
 }
 
 #print Dumper(\@updates);
 
-open U, "|git update-ref -m 'dgit bad commit fixup' --stdin" or die $!;
+open U, "|git update-ref -m 'dgit bad commit fixup' --stdin" or die $!
+    if $real >= 0;
 
 for my $up (@updates) {
     my ($ref, $old, $new, $nobackup) = @$up;
     my $otherref = $ref;
     $otherref =~ s{^refs/}{};
-    if ($real) {
+    if ($real > 0) {
 	print U <<END or die $! unless $nobackup;
 create refs/dgit-badcommit/$otherref $old
 END
 	print U <<END or die $!;
 update $ref $new $old
 END
-    } else {
+    } elsif ($real==0) {
 	print U <<END or die $!;
 update refs/dgit-badfixuptest/$otherref $new
 END
+    } else {
+	print "found trouble in history of $ref\n" or die $!;
     }
 }
 
-$?=0; $!=0;
-close U or die "$? $!";
-die $? if $?;
+if ($real >= 0) {
+    $?=0; $!=0;
+    close U or die "$? $!";
+    die $? if $?;
+}
 
 print Dumper(\%count);
 
-if ($real) {
+if ($real >= 0) {
     print "old values saved in refs/dgit-badcommit/\n" or die $!;
-} else {
+} elsif ($real == 0) {
     print "testing output saved in refs/dgit-badfixuptest/\n" or die $!;
+} else {
+    print STDERR "found work to do, exiting status 2\n";
+    exit 2;
 }