From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun, 12 Oct 2014 19:34:42 +0000 (+0100)
Subject: src/types.c: Clarify addr_rrtypeflag loop (style)
X-Git-Tag: adns-1.5.0-rc0~32
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=adns.git;a=commitdiff_plain;h=2140e71d5b1140845b45fbb2cb21f97d5e34c3dc

src/types.c: Clarify addr_rrtypeflag loop (style)

This structure avoids repeating the loop termination condition.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/src/types.c b/src/types.c
index 55a7709..5062c6a 100644
--- a/src/types.c
+++ b/src/types.c
@@ -373,8 +373,10 @@ static unsigned addr_rrtypeflag(adns_rrtype type) {
   int i;
 
   type &= adns_rrt_typemask;
-  for (i=0; i<addr_nrrtypes && type!=addr_all_rrtypes[i]; i++);
-  return i < addr_nrrtypes ? 1 << i : 0;
+  for (i=0; i<addr_nrrtypes; i++)
+     if (type==addr_all_rrtypes[i])
+       return 1 << i;
+  return 0;
 }
 
 /* About CNAME handling in addr queries.