X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=adns.git;a=blobdiff_plain;f=src%2Ftypes.c;h=83a57927ad9f74f019240ec564a5c5490561af68;hp=675442c3344d6c878a94c5e7fa03aec0c8b113ff;hb=d24b603f667154672b74ea6a3e428bb19ba91089;hpb=e8e5aeacbdaf5654974626d548f30a4c86e5ced6 diff --git a/src/types.c b/src/types.c index 675442c..83a5792 100644 --- a/src/types.c +++ b/src/types.c @@ -58,7 +58,7 @@ * _mx (pa,di) * _inthostaddr (mf,cs) * _inthost (cs) - * _ptr (pa) + * _ptr (ckl,pa +icb_ptr) * _strpair (mf) * _intstrpair (mf) * _hinfo (pa) @@ -704,12 +704,42 @@ static adns_status cs_inthost(vbuf *vb, const void *datap) { } /* - * _ptr (pa, +icb_ptr) + * _ptr (ckl,pa +icb_ptr) */ +static adns_status ckl_ptr(adns_state ads, adns_queryflags flags, + union checklabel_state *cls, qcontext *ctx, + int labnum, const char *label, int lablen) { + static const char *const (expectdomain[])= { DNS_INADDR_ARPA }; + char *ep; + const char *ed; + char labbuf[4]; + int l; + + if (labnum < 4) { + if (lablen<=0 || lablen>3) return adns_s_querydomainwrong; + memcpy(labbuf, label, lablen); + labbuf[lablen]= 0; + cls->ptr.ipv[3-labnum]= strtoul(labbuf,&ep,10); + if (*ep) return adns_s_querydomainwrong; + if (lablen>1 && *label=='0') return adns_s_querydomainwrong; + } else if (labnum < 4 + sizeof(expectdomain)/sizeof(*expectdomain)) { + ed= expectdomain[labnum-4]; + l= strlen(ed); + if (lablen != l || memcmp(label, ed, l)) return adns_s_querydomainwrong; + } else { + if (lablen) return adns_s_querydomainwrong; + ctx->tinfo.ptr.addr.s_addr= + htonl((cls->ptr.ipv[0]<<24) | (cls->ptr.ipv[1]<<16) | + (cls->ptr.ipv[2]<< 8) | (cls->ptr.ipv[3])); + } + return adns_s_ok; +} + static void icb_ptr(adns_query parent, adns_query child) { adns_answer *cans= child->answer; - const adns_rr_addr *queried, *found; + const struct in_addr *queried; + const unsigned char *found; adns_state ads= parent->ads; int i; @@ -721,10 +751,9 @@ static void icb_ptr(adns_query parent, adns_query child) { return; } - queried= &parent->ctx.tinfo.ptr_addr; - for (i=0, found=cans->rrs.addr; inrrs; i++, found++) { - if (queried->len == found->len && - !memcmp(&queried->addr,&found->addr,queried->len)) { + queried= &parent->ctx.tinfo.ptr.addr; + for (i=0, found=cans->rrs.bytes; inrrs; i++, found+=cans->rrsz) { + if (!memcmp(queried,found,cans->rrsz)) { if (!parent->children.head) { adns__query_done(parent); return; @@ -740,16 +769,9 @@ static void icb_ptr(adns_query parent, adns_query child) { static adns_status pa_ptr(const parseinfo *pai, int dmstart, int max, void *datap) { - static const char *const (expectdomain[])= { DNS_INADDR_ARPA }; - char **rrp= datap; adns_status st; - adns_rr_addr *ap; - findlabel_state fls; - char *ep; - byte ipv[4]; - char labbuf[4]; - int cbyte, i, lablen, labstart, l, id; + int cbyte, id; adns_query nqu; qcontext ctx; @@ -759,48 +781,16 @@ static adns_status pa_ptr(const parseinfo *pai, int dmstart, if (st) return st; if (cbyte != max) return adns_s_invaliddata; - ap= &pai->qu->ctx.tinfo.ptr_addr; - if (!ap->len) { - adns__findlabel_start(&fls, pai->ads, -1, pai->qu, - pai->qu->query_dgram, pai->qu->query_dglen, - pai->qu->query_dglen, DNS_HDRSIZE, 0); - for (i=0; i<4; i++) { - st= adns__findlabel_next(&fls,&lablen,&labstart); assert(!st); - if (lablen<=0 || lablen>3) return adns_s_querydomainwrong; - memcpy(labbuf, pai->qu->query_dgram + labstart, lablen); - labbuf[lablen]= 0; - ipv[3-i]= strtoul(labbuf,&ep,10); - if (*ep) return adns_s_querydomainwrong; - if (lablen>1 && pai->qu->query_dgram[labstart]=='0') - return adns_s_querydomainwrong; - } - for (i=0; iqu->query_dgram + labstart, expectdomain[i], l)) - return adns_s_querydomainwrong; - } - st= adns__findlabel_next(&fls,&lablen,0); assert(!st); - if (lablen) return adns_s_querydomainwrong; - - ap->len= sizeof(struct sockaddr_in); - memset(&ap->addr,0,sizeof(ap->addr.inet)); - ap->addr.inet.sin_family= AF_INET; - ap->addr.inet.sin_addr.s_addr= - htonl((ipv[0]<<24) | (ipv[1]<<16) | (ipv[2]<<8) | (ipv[3])); - } - st= adns__mkquery_frdgram(pai->ads, &pai->qu->vb, &id, pai->dgram, pai->dglen, dmstart, - adns_r_addr, adns_qf_quoteok_query); + adns_r_a, adns_qf_quoteok_query); if (st) return st; ctx.ext= 0; ctx.callback= icb_ptr; memset(&ctx.pinfo,0,sizeof(ctx.pinfo)); memset(&ctx.tinfo,0,sizeof(ctx.tinfo)); - st= adns__internal_submit(pai->ads, &nqu, adns__findtype(adns_r_addr), + st= adns__internal_submit(pai->ads, &nqu, adns__findtype(adns_r_a), &pai->qu->vb, id, adns_qf_quoteok_query, pai->now, &ctx); if (st) return st; @@ -1232,11 +1222,11 @@ static void mf_flat(adns_query qu, void *data) { } #define TYPESZ_M(member) (sizeof(*((adns_answer*)0)->rrs.member)) #define DEEP_TYPE(code,rrt,fmt,memb,parser,comparer,/*printer*/...) \ - { adns_r_##code, rrt,fmt,TYPESZ_M(memb), mf_##memb, \ + { adns_r_##code&adns_rrt_reprmask, rrt,fmt,TYPESZ_M(memb), mf_##memb, \ GLUE(cs_, CAR(__VA_ARGS__)),pa_##parser,di_##comparer, \ adns__ckl_hostname, CDR(__VA_ARGS__) } #define FLAT_TYPE(code,rrt,fmt,memb,parser,comparer,/*printer*/...) \ - { adns_r_##code, rrt,fmt,TYPESZ_M(memb), mf_flat, \ + { adns_r_##code&adns_rrt_reprmask, rrt,fmt,TYPESZ_M(memb), mf_flat, \ GLUE(cs_, CAR(__VA_ARGS__)),pa_##parser,di_##comparer, \ adns__ckl_hostname, CDR(__VA_ARGS__) } @@ -1260,7 +1250,8 @@ DEEP_TYPE(srv_raw,"SRV", "raw",srvraw , srvraw, srv, srvraw, FLAT_TYPE(addr, "A", "addr", addr, addr, addr, addr ), DEEP_TYPE(ns, "NS", "+addr",hostaddr, hostaddr,hostaddr,hostaddr ), -DEEP_TYPE(ptr, "PTR","checked",str, ptr, 0, domain ), +DEEP_TYPE(ptr, "PTR","checked",str, ptr, 0, domain, + .checklabel= ckl_ptr), DEEP_TYPE(mx, "MX", "+addr",inthostaddr,mx, mx, inthostaddr, ), DEEP_TYPE(srv, "SRV","+addr",srvha, srvha, srv, srvha, .checklabel= ckl_srv, .postsort= postsort_srv), @@ -1276,6 +1267,7 @@ const typeinfo *adns__findtype(adns_rrtype type) { const typeinfo *begin, *end, *mid; if (type & adns_r_unknown) return &typeinfo_unknown; + type &= adns_rrt_reprmask; begin= typeinfos; end= typeinfos+(sizeof(typeinfos)/sizeof(typeinfo));