From d1ab75d7d23a86466891439d9cb25547a4c25c76 Mon Sep 17 00:00:00 2001
From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed, 23 Feb 2022 19:40:48 +0000
Subject: [PATCH] fairphone4-case: wip apertures, etc.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---
 fairphone4-case.scad | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/fairphone4-case.scad b/fairphone4-case.scad
index 15db45e..cd147af 100644
--- a/fairphone4-case.scad
+++ b/fairphone4-case.scad
@@ -158,7 +158,7 @@ jack_pos = [ 13.83, 8.485 ];
 jack_dia = 10.64 + .5; // some jack I had lying around
 
 // this led stuff, is irrelevant, we have disabled it as it doesn't have one
-led_pos = [ 13.98, 10.00 ];
+led_pos = []; // [ 13.98, 10.00 ];
 led_aperture = 9;
 led_window_ledge = 0.75; // each side
 
@@ -170,14 +170,14 @@ mainmic_dia = 4.00;
 
 lhshole_pos = [ phone[1]/2, 4.35 ];
 
-// fingerpushhole_dias = []; xxx what was this
-fingerpushhole_dias = [ 15, 18 ];
+// fingerpushhole_dias = [];
+fingerpushhole_dias = [ 15, 18 ]; // this is for testing
 
 lanyard_half_dia = 1.15;
 lanyard_entry_rel_breadth = 2;
 lanyard_channel_len = 8;
-rearspeaker_pos_bl = [ 12.64, 18.72 ];
-rearspeaker_size   = [  3.76,  7.36 ];
+//rearspeaker_pos_bl = [ 12.64, 18.72 ];
+//rearspeaker_size   = [  3.76,  7.36 ];
 
 bottomspeaker_size = [ 11.35, 1.40 ] + [1,1] * 0.5;
 bottomspeaker_pos = [ 19.45, 4.82 ];
@@ -261,8 +261,8 @@ hinge_x_arms_gap = 0.35;
 hinge_r_arms_gap = 0.55;
 hinge_over_nut_plate = 1.0;
 
-// xxx there isn't one of these, speaker is by hinge
-rearspeaker_gap    = [ 2.0, 2.0 ]; // each side
+// there isn't one of these, speaker is by hinge
+// rearspeaker_gap    = [ 2.0, 2.0 ]; // each side
 
 thumbrecess_depth = 1.3;
 thumbrecess_width = 16.5;
@@ -894,13 +894,13 @@ module OrdinaryBottomEdgeApertures(){
 
 module OrdinaryRearApertures(){
   // rear speaker
-  OrdinaryRearAperture(1,1, rearspeaker_pos_bl)
-    rectfromto(-rearspeaker_gap,
-	       rearspeaker_size + rearspeaker_gap);
+  //  OrdinaryRearAperture(1,1, rearspeaker_pos_bl)
+  //    rectfromto(-rearspeaker_gap,
+  //	       rearspeaker_size + rearspeaker_gap);
 
   // finger hole to remove phone
   if (len(fingerpushhole_dias))
-    OrdinaryRearAperture(1,0, [ fingerpushhole_dias[0]/2 + epp2i[0],
+    OrdinaryRearAperture(0,0, [ fingerpushhole_dias[0]/2 + epp2i[0],
 				phone[1]/2 ])
     scale(fingerpushhole_dias)
     circle(r= 0.5 );
@@ -1511,7 +1511,8 @@ module TestSelectFrame(){
 
 module TestSelectLidFrame(){
   TestSelectFrame();
-  translate([led_pos[0], -led_pos[1], -50])
+  if (len(led_pos))
+    translate([led_pos[0], -led_pos[1], -50])
     cylinder(r= nla_r2+3, h=100);
 }
 
-- 
2.30.2