From b1ce87e4f8f529b681495b9cbdf3df81b6baae3c Mon Sep 17 00:00:00 2001
From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat, 13 Feb 2016 20:00:53 +0000
Subject: [PATCH] bike-lipo-box: TestWall: replace ad-hoc with S1930_Positive
 (nfc)

---
 bike-lipo-box.scad.m4 | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/bike-lipo-box.scad.m4 b/bike-lipo-box.scad.m4
index d18e96d..b3dd3db 100644
--- a/bike-lipo-box.scad.m4
+++ b/bike-lipo-box.scad.m4
@@ -13,11 +13,26 @@ s1930_x_outer = 27.6 + 0.2;
 
 s1930_recess = 3;
 s1930_around = 3;
+s1930_behind = 3;
 
 wallthick = 2.5;
 
+// origin is at centre on outer face wall
+// outside is towards positive x
+// mounting is vertical
+module S1930_Positive(){
+  d = s1930_recess + s1930_behind;
+  translate([-d/2, 0,0])
+    cube([d,
+	  s1930_x_outer + s1930_around,
+	  s1930_y_outer + s1930_around], center=true);
+}
+
 module TestWall(){ ////toplevel
   sw_ctr = [25, 0, 25];
+  sw_ctr_new = [25,
+		wallthick + 0.5, // xxx compatibility bug
+		25];
 
   rotate([0,0,-90]){
     difference(){
@@ -37,13 +52,9 @@ module TestWall(){ ////toplevel
   difference(){
     union(){
       cube([50, wallthick, 50]);
-      translate(sw_ctr) {
-	rotate([90,0,0])
-	  cube([s1930_x_outer + s1930_around,
-		s1930_y_outer + s1930_around,
-		s1930_recess*2],
-	       center=true);
-      }
+      translate(sw_ctr_new)
+	rotate([0,0,90])
+	S1930_Positive();
     }
 
     translate(sw_ctr) {
-- 
2.30.2