From 8fe84405ca83b2451e42b7c7f05ac4a5dc1229fd Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Sat, 13 Feb 2016 22:00:36 +0000 Subject: [PATCH] sealing-box, bike-lipo-box: $-ise many more vars (nfc) --- bike-lipo-box.scad | 27 +++++++++++++++------------ sealing-box.scad.m4 | 42 +++++++++++++++++++++++++----------------- 2 files changed, 40 insertions(+), 29 deletions(-) diff --git a/bike-lipo-box.scad b/bike-lipo-box.scad index bde5ece..4cc52de 100644 --- a/bike-lipo-box.scad +++ b/bike-lipo-box.scad @@ -68,40 +68,43 @@ module TestWall(){ ////toplevel } } +totx_outer = 30; +toty_outer = 25; +totz_inner = 8; + $sealingbox_wallthick = wallthick; +$sealingbox_floorth = 2.5; +$sealingbox_ceilth = 2.5; +$sealingbox_xbox = totx_outer; +$sealingbox_ybox = toty_outer; +$sealingbox_zbox = totz_inner; -floorth = 2.5; -ceilth = 2.5; innertube = 1.0 + 0.2; lidoverlap = 1.5; lidoverhang = 6; tubesealrad = 2.0; - -ts_xbox = 30; -ts_ybox = 25; ts_cnrrad = 10; -ts_zbox = 8; include module TestSealBox(){ ////toplevel TestSealBoxBox(); translate(ts_cidoff) - Commitid_BestCount([ts_xbox,ts_ybox] - 2*ts_cidoff); + Commitid_BestCount([totx_outer,toty_outer] - 2*ts_cidoff); } module TestSealLid(){ ////toplevel difference(){ TestSealBoxLid(); - translate([ts_xbox * .75, ts_ybox/2, 0]) + translate([totx_outer * .75, toty_outer/2, 0]) cylinder(h=100, r=5); translate([-wallthick + ts_cnrrad*.5, ts_cnrrad*.5 - wallthick, - ts_zbox + ceilth]) - Commitid_BestCount([ts_xbox * .75 - 2.5 - (ts_cnrrad*.5), - ts_ybox - (ts_cnrrad*.5 - wallthick)*2]); + totz_inner + $sealingbox_ceilth]) + Commitid_BestCount([totx_outer * .75 - 2.5 - (ts_cnrrad*.5), + toty_outer - (ts_cnrrad*.5 - wallthick)*2]); } } @@ -114,7 +117,7 @@ module ProfileDemos(){ ////toplevel color("blue") SealingBox_FloorProfile(); SealingBox_LidProfile(); color("blue") SealingBox_CeilProfile(); - color("red") translate([-5,0]) square([1,ts_zbox]); + color("red") translate([-5,0]) square([1,totz_inner]); } //TestWall(); diff --git a/sealing-box.scad.m4 b/sealing-box.scad.m4 index a076ddd..80f3c33 100644 --- a/sealing-box.scad.m4 +++ b/sealing-box.scad.m4 @@ -6,9 +6,12 @@ // 1. include // 2. assign() values to (xxx these should be $ variables) // $sealingbox_wallthick -// ts_xbox (outer dimensions) -// ts_ybox (outer dimension) -// ts_zbox (??? xxx) +// $sealingbox_xbox (outer dimension) +// $sealingbox_ybox (outer dimension) +// $sealingbox_zbox (inner dimension xxx) +// $sealingbox_ceilth +// $sealingbox_floorth +// $sealingbox_wallthick // ts_cnrrad (outer radius of corners, leave at default normall) // xxx default should be in this file // 3. use the modules @@ -23,11 +26,16 @@ m4_define(`BoxLocals',` wall = $sealingbox_wallthick; + floorth = $sealingbox_floorth; + ceilth = $sealingbox_ceilth; + xbox = $sealingbox_xbox; + ybox = $sealingbox_ybox; + zbox = $sealingbox_zbox; ts_cidoff = (ts_cnrrad * (1-.7) + wall * .8) * [1,1]; - ts_xbox_lin = ts_xbox - ts_cnrrad*2; - ts_ybox_lin = ts_ybox - ts_cnrrad*2; + xbox_lin = xbox - ts_cnrrad*2; + ybox_lin = ybox - ts_cnrrad*2; ') m4_dnl Box_Part($1=transl_x,$2=transl_y, $3=rot_z,$4=mirror_xy) @@ -73,13 +81,13 @@ m4_define(`BoxPart_Extrude_Arc',` m4_dnl BoxDoShapeRect(`profile(profileargs)'); m4_define(`BoxDoShapeRect',` - Box_Part(0, ts_cnrrad, 0,0, Linear,`ts_ybox_lin', `$1' ) - Box_Part(0, ts_ybox-ts_cnrrad, 0,0, Arc,`-ts_cnrrad,90' , `$1' ) - Box_Part(ts_cnrrad, ts_ybox, -90,0, Linear,`ts_xbox_lin', `$1' ) - Box_Part(ts_xbox-ts_cnrrad, ts_ybox, -90,0, Arc,`-ts_cnrrad,90' , `$1' ) - Box_Part(ts_xbox, ts_ybox-ts_cnrrad, -180,0, Linear,`ts_ybox_lin', `$1' ) - Box_Part(ts_xbox, ts_cnrrad, -180,0, Arc,`-ts_cnrrad,90' , `$1' ) - Box_Part(ts_xbox-ts_cnrrad, 0, -270,0, Linear,`ts_xbox_lin', `$1' ) + Box_Part(0, ts_cnrrad, 0,0, Linear,`ybox_lin', `$1' ) + Box_Part(0, ybox-ts_cnrrad, 0,0, Arc,`-ts_cnrrad,90' , `$1' ) + Box_Part(ts_cnrrad, ybox, -90,0, Linear,`xbox_lin', `$1' ) + Box_Part(xbox-ts_cnrrad, ybox, -90,0, Arc,`-ts_cnrrad,90' , `$1' ) + Box_Part(xbox, ybox-ts_cnrrad, -180,0, Linear,`ybox_lin', `$1' ) + Box_Part(xbox, ts_cnrrad, -180,0, Arc,`-ts_cnrrad,90' , `$1' ) + Box_Part(xbox-ts_cnrrad, 0, -270,0, Linear,`xbox_lin', `$1' ) Box_Part(ts_cnrrad, 0, -270,0, Arc,`-ts_cnrrad,90' , `$1' ) ') @@ -87,7 +95,7 @@ m4_dnl ' module SealingBox_WallProfile(){ BoxLocals - z = ts_zbox - innertube - tubesealrad; + z = zbox - innertube - tubesealrad; translate([0, -0.1]) square([wall, z]); translate([tubesealrad, z]) circle(r=tubesealrad, $fn=20); } @@ -103,15 +111,15 @@ module SealingBox_LidProfile(){ morex = wall; difference(){ translate([-lidoverlap - innertube, - ts_zbox - lidoverhang - innertube]) + zbox - lidoverhang - innertube]) square([lidoverlap + innertube + wall, lidoverhang + innertube + ceilth]); hull(){ translate([tubesealrad, - ts_zbox - innertube - tubesealrad]) + zbox - innertube - tubesealrad]) for (t=[ [0,0], [morex*2, 0], - [0, -ts_zbox] + [0, -zbox] ]) { translate(t) circle(r= tubesealrad + innertube, $fn=20); @@ -122,7 +130,7 @@ module SealingBox_LidProfile(){ module SealingBox_CeilProfile(){ BoxLocals - translate([0, ts_zbox]) + translate([0, zbox]) square([wall*2, ceilth]); } -- 2.30.2