From 84568c15a67f54cecdbdd5f19573abbc3e9016e0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20Mart=C3=AD?= Date: Fri, 15 Jan 2016 00:19:11 +0100 Subject: [PATCH] Fix detection of pyflakes3 found in Debian --- hooks/pre-commit | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/hooks/pre-commit b/hooks/pre-commit index 53479051..f0e4d657 100755 --- a/hooks/pre-commit +++ b/hooks/pre-commit @@ -70,22 +70,21 @@ cmd_exists() { command -v $1 1>/dev/null } -if cmd_exists pyflakes-python3; then - PYFLAKES=pyflakes-python3 -elif cmd_exists pyflakes; then - PYFLAKES=pyflakes -else - PYFLAKES=echo - warn "pyflakes is not installed, using dummy placeholder!" -fi +find_command() { + local name=$1 + for suff in "3" "-python3" ""; do + cmd=${1}${suff} + if cmd_exists $cmd; then + echo -n $cmd + return 0 + fi + done + warn "$1 is not installed, using dummy placeholder!" + echo -n echo +} -if cmd_exists pep8-python3; then - PEP8=pep8-python3 -elif cmd_exists pep8; then - PEP8=pep8 -else - err "pep8 is not installed!" -fi +PYFLAKES=$(find_command pyflakes) +PEP8=$(find_command pep8) if [ "$PY_FILES $PY_TEST_FILES" != " " ]; then if ! $PYFLAKES $PY_FILES $PY_TEST_FILES; then -- 2.30.2