From 5faef55d67788331f362b42f6a5a8e5cd509a055 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Thu, 13 Oct 2016 16:50:31 +0200 Subject: [PATCH] support all valid versionCode values, i.e. Java Integer values versionCode can be any Java Integer value, from Integer.MAX_VALUE (2147483648) to Integer.MIN_VALUE (-2147483647) --- fdroidserver/update.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fdroidserver/update.py b/fdroidserver/update.py index 7e1181d1..d18f0fd3 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -1444,12 +1444,15 @@ def main(): else: archapks = [] + # less than the valid range of versionCode, i.e. Java's Integer.MIN_VALUE + UNSET_VERSION_CODE = -0x100000000 + # Some information from the apks needs to be applied up to the application # level. When doing this, we use the info from the most recent version's apk. # We deal with figuring out when the app was added and last updated at the # same time. for appid, app in apps.items(): - bestver = 0 + bestver = UNSET_VERSION_CODE for apk in apks + archapks: if apk['id'] == appid: if apk['versioncode'] > bestver: @@ -1467,7 +1470,7 @@ def main(): if not app.lastupdated: logging.debug("Don't know when " + appid + " was last updated") - if bestver == 0: + if bestver == UNSET_VERSION_CODE: if app.Name is None: app.Name = app.AutoName or appid app.icon = None -- 2.30.2