From 41fd1e86af2a3cf297efc83767954a77886d3e9c Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20Mart=C3=AD?= Date: Tue, 18 Aug 2015 18:13:18 -0700 Subject: [PATCH] lint: also do http warnings on descriptions --- fdroidserver/lint.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py index ee6eca7c..61b2b639 100644 --- a/fdroidserver/lint.py +++ b/fdroidserver/lint.py @@ -122,6 +122,8 @@ categories = Set([ "Wallpaper", ]) +desc_url = re.compile("[^[]\[([^ ]+)( |\]|$)") + def main(): @@ -247,6 +249,13 @@ def main(): for l in app['Description']: if len(l) < 1: continue + + for um in desc_url.finditer(l): + url = um.group(1) + for m, r in http_warnings: + if m.match(url): + warn("URL '%s' in Description: %s" % (url, r)) + c = l.decode('utf-8')[0] if c == lchar: lcount += 1 @@ -265,7 +274,7 @@ def main(): if v is None: continue if m.match(v): - warn("%s '%s': %s" % (f, app[f], r)) + warn("%s '%s': %s" % (f, v, r)) elif type(v) == list: for l in v: if m.match(l): -- 2.30.2