From 29aaa6fef99f83e54baed130cb5380294ae2b152 Mon Sep 17 00:00:00 2001 From: Sven Eden Date: Fri, 2 Feb 2018 07:15:23 +0100 Subject: [PATCH] tools/check-includes.pl : Fixed errors. The constant long list of errors in Eclipse Epic drove me nuts. ;-) --- tools/check-includes.pl | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tools/check-includes.pl b/tools/check-includes.pl index bf23929d4..d93b5668a 100755 --- a/tools/check-includes.pl +++ b/tools/check-includes.pl @@ -3,21 +3,23 @@ # checkincludes: Find files included more than once in (other) files. # Copyright abandoned, 2000, Niels Kristian Bech Jensen . -foreach $file (@ARGV) { - open(FILE, $file) or die "Cannot open $file: $!.\n"; +use strict; +use warnings; +foreach my $file (@ARGV) { my %includedfiles = (); - while () { + open(my $FILE, "<", $file) or die "Cannot open $file: $!.\n"; + while (<$FILE>) { if (m/^\s*#\s*include\s*[<"](\S*)[>"]/o) { ++$includedfiles{$1}; } } - foreach $filename (keys %includedfiles) { + close($FILE); + + foreach my $filename (keys %includedfiles) { if ($includedfiles{$filename} > 1) { print "$file: $filename is included more than once.\n"; } } - - close(FILE); } -- 2.30.2