From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 28 Jan 2016 17:53:34 +0000 (+0100)
Subject: systemctl: improve message when a job fails with a JOB_INVALID state
X-Git-Tag: v229.1~1^2~40
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=f959e21a0603238f2e4566cf92266f50b59c7476;p=elogind.git

systemctl: improve message when a job fails with a JOB_INVALID state

This result can only happen if the job was a reload job for an inactive unit. Make the error message actually say that.
---

diff --git a/src/shared/bus-util.c b/src/shared/bus-util.c
index a29121748..c12795d1f 100644
--- a/src/shared/bus-util.c
+++ b/src/shared/bus-util.c
@@ -2097,7 +2097,7 @@ static int check_wait_response(BusWaitForJobs *d, bool quiet, const char *extra_
                 else if (streq(d->result, "dependency"))
                         log_error("A dependency job for %s failed. See 'journalctl -xe' for details.", strna(d->name));
                 else if (streq(d->result, "invalid"))
-                        log_error("Job for %s invalid.", strna(d->name));
+                        log_error("%s is not active, cannot reload.", strna(d->name));
                 else if (streq(d->result, "assert"))
                         log_error("Assertion failed on job for %s.", strna(d->name));
                 else if (streq(d->result, "unsupported"))