From: Olivier Brunel Date: Sun, 4 Nov 2012 23:28:45 +0000 (+0100) Subject: systemd: highlight ordering cycle deletions X-Git-Tag: v196~76 X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=f09a7d25545b5e3a2dd3dfc1ff7ebc8560a3354c;p=elogind.git systemd: highlight ordering cycle deletions Having unit(s) removed/not started, even if it solved the issue and allowed to boot successfully, should still be considered an error, as something clearly isn't right. This patch elevates the log message from warning to error, and adds a status message to make things more obvious. --- diff --git a/src/core/transaction.c b/src/core/transaction.c index 4bce94201..ee6992a81 100644 --- a/src/core/transaction.c +++ b/src/core/transaction.c @@ -374,7 +374,8 @@ static int transaction_verify_order_one(Transaction *tr, Job *j, Job *from, unsi if (delete) { - log_warning("Breaking ordering cycle by deleting job %s/%s", delete->unit->id, job_type_to_string(delete->type)); + log_error("Breaking ordering cycle by deleting job %s/%s", delete->unit->id, job_type_to_string(delete->type)); + status_printf(ANSI_HIGHLIGHT_RED_ON " SKIP " ANSI_HIGHLIGHT_OFF, true, "Ordering cycle found, skip %s", unit_description(delete->unit)); transaction_delete_unit(tr, delete->unit); return -EAGAIN; }