From: Tom Gundersen <teg@jklm.no>
Date: Tue, 3 Jun 2014 09:46:25 +0000 (+0200)
Subject: shared: capability - don't loop over the cap bits if they are all unset
X-Git-Tag: v214~103
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=e5999b46792b859043a62431d426a280f26a16d7;p=elogind.git

shared: capability - don't loop over the cap bits if they are all unset
---

diff --git a/src/shared/capability.c b/src/shared/capability.c
index 58270ad8c..439aac7ea 100644
--- a/src/shared/capability.c
+++ b/src/shared/capability.c
@@ -264,11 +264,11 @@ int drop_privileges(uid_t uid, gid_t gid, uint64_t keep_capabilities) {
         if (!d)
                 return log_oom();
 
-        for (i = 0; i < sizeof(keep_capabilities)*8; i++)
-                if (keep_capabilities & (1ULL << i))
-                        bits[j++] = i;
-
         if (keep_capabilities) {
+                for (i = 0; i < sizeof(keep_capabilities)*8; i++)
+                        if (keep_capabilities & (1ULL << i))
+                                bits[j++] = i;
+
                 if (cap_set_flag(d, CAP_EFFECTIVE, j, bits, CAP_SET) < 0 ||
                     cap_set_flag(d, CAP_PERMITTED, j, bits, CAP_SET) < 0) {
                         log_error("Failed to enable capabilities bits: %m");