From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Thu, 24 Nov 2022 00:02:20 +0000 (+0000)
Subject: polypath: Do not separately log xmit failures
X-Git-Tag: v0.6.7~12
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=e4dbf24823b262eb038833fbf82ad688fe1cc5e4;p=secnet.git

polypath: Do not separately log xmit failures

udp_sock_experienced handles the necessary logging.  We don't want a
log message per packet, even if they're errors.

Empirically, using a network speed test web page, over the same
network interface, can cause this to get EAGAIN and produce logspam.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/polypath.c b/polypath.c
index 64284a3..adac598 100644
--- a/polypath.c
+++ b/polypath.c
@@ -504,9 +504,6 @@ static void polypath_sendmsg_interf(struct polypath *st,
 	}
 	if (!(errno==EAFNOSUPPORT || errno==ENETUNREACH))
 	    reasonable=True;
-	lg_perror(LG,M_DEBUG,errno,"%s [%s] xmit %"PRIu32" bytes to %s",
-		  interf->name,iaddr_to_string(&us->addr),
-		  buf->size,iaddr_to_string(&dest->ia));
     }
     if (!wanted)
 	return;