From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri, 28 Sep 2018 17:04:03 +0000 (+0100)
Subject: test suite: t-check-only-bpd: Check $tmp/.. not ..
X-Git-Tag: archive/debian/6.12~1
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=df4419b77d5e231b7861a03542a22e36b0cda065;p=dgit.git

test suite: t-check-only-bpd: Check $tmp/.. not ..

The test might call t-ok in $p, say, or in $tmp.

The effect of this bug was that in tests where t-ok was called in
$tmp, it looked in $tmp/.. which might contain anything, rather than
$tmp as intended.  That means the test was not effective.

Also it causes a spurious failure of t-import-nonnative in the Ubuntu
CI infrastructure, where $AUTOPKGTEST_TMP/../autopkgtest-satdep.deb
happens to exist.

Reported-by: Mattia Rizzolo <mattia@debian.org>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/tests/lib b/tests/lib
index 57b9e38e..a4f307f8 100644
--- a/tests/lib
+++ b/tests/lib
@@ -407,8 +407,8 @@ t-git-fsck () {
 t-check-only-bpd () {
 	if [ "$bpd" = .. ]; then return; fi
 	t-files-notexist \
-		../*.{deb,changes,dsc,buildinfo} \
-		../*.{tar,diff}.*
+		$tmp/*.{deb,changes,dsc,buildinfo} \
+		$tmp/*.{tar,diff}.*
 }
 
 t-fscks () {