From: Daniel Martí <mvdan@mvdan.cc>
Date: Mon, 11 Jan 2016 12:25:03 +0000 (+0100)
Subject: metadata: slightly speed up post_metadata_parse
X-Git-Tag: 0.7.0~86^2~6
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=d98b4d1b831f008ab358a03be6b23f54bf004b24;p=fdroidserver.git

metadata: slightly speed up post_metadata_parse

Iterating over all the fields and checking which are modified is slower
than just iterating over the modified ones.
---

diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py
index 5d4c0b5b..0112a0ec 100644
--- a/fdroidserver/metadata.py
+++ b/fdroidserver/metadata.py
@@ -842,17 +842,14 @@ esc_newlines = re.compile(r'\\( |\n)')
 # This function uses __dict__ to be faster
 def post_metadata_parse(app):
 
-    for k, v in app.__dict__.items():
-        if k not in app._modified:
-            continue
+    for k in app._modified:
+        v = app.__dict__[k]
         if type(v) in (float, int):
             app.__dict__[k] = str(v)
 
     for build in app.builds:
-        for k, v in build.__dict__.items():
-
-            if k not in build._modified:
-                continue
+        for k in build._modified:
+            v = build.__dict__[k]
             if type(v) in (float, int):
                 build.__dict__[k] = str(v)
                 continue