From: Daniel Martí <mvdan@mvdan.cc>
Date: Wed, 19 Aug 2015 00:54:32 +0000 (-0700)
Subject: Warn about url shorteners being used
X-Git-Tag: 0.5.0~192
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=d0559f864e4f578e6794f3b24a832d44ccd4af52;p=fdroidserver.git

Warn about url shorteners being used
---

diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py
index 189b52ed..9c59fd37 100644
--- a/fdroidserver/lint.py
+++ b/fdroidserver/lint.py
@@ -44,7 +44,18 @@ https_enforcings = [
     enforce_https('googlecode.com'),
 ]
 
-http_warnings = https_enforcings + [
+
+def forbid_shortener(domain):
+    return (re.compile(r'https?://[^/]*' + re.escape(domain) + r'/.*'),
+            "URL shorteners should not be used")
+
+http_url_shorteners = [
+    forbid_shortener('goo.gl'),
+    forbid_shortener('t.co'),
+    forbid_shortener('ur1.ca'),
+]
+
+http_warnings = https_enforcings + http_url_shorteners + [
     (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
      "Appending .git is not necessary"),
     # TODO enable in August 2015, when Google Code goes read-only