From: Daniel Martí <mvdan@mvdan.cc>
Date: Thu, 3 Dec 2015 18:31:20 +0000 (+0100)
Subject: Fix tests by not checking private attributes
X-Git-Tag: 0.6.0~60
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=cb8d93e44340e71dc431ea1428bdecda5f15922e;p=fdroidserver.git

Fix tests by not checking private attributes

All attrs starting with '_' (e.g. _foo or __bar) are used internally, so
not very relevant for the metadata test anyway.
---

diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py
index bcc41096..e31cf364 100644
--- a/fdroidserver/metadata.py
+++ b/fdroidserver/metadata.py
@@ -162,10 +162,11 @@ class App():
             if k == 'builds':
                 d['builds'] = []
                 for build in v:
-                    d['builds'].append(build.__dict__)
-            else:
-                k = App.attr_to_field(k)
-                d[k] = v
+                    b = {k: v for k, v in build.__dict__.iteritems() if not k.startswith('_')}
+                    d['builds'].append(b)
+            elif not k.startswith('_'):
+                f = App.attr_to_field(k)
+                d[f] = v
         return d
 
     # Gets the value associated to a field name, e.g. 'Auto Name'