From: Daniel Martí <mvdan@mvdan.cc>
Date: Mon, 20 Jan 2014 10:10:00 +0000 (+0100)
Subject: Warn about branches used in commit=
X-Git-Tag: 0.2~389
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=c9d8146f9e65536fb2daa687df90e57cd3523bbf;p=fdroidserver.git

Warn about branches used in commit=
---

diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py
index 3fbf89c6..de805527 100644
--- a/fdroidserver/lint.py
+++ b/fdroidserver/lint.py
@@ -109,6 +109,15 @@ def main():
                 if m.match(app[f]):
                     warn("%s url '%s': %s" % (f, app[f], r))
 
+        # Build warnings
+        for build in app['builds']:
+            for n in ['master', 'origin/', 'default', 'trunk']:
+                if 'commit' not in build:
+                    continue
+                if build['commit'].startswith(n):
+                    warn("Branch '%s' used as commit" % n)
+
+
         if not appid:
             print