From: Ronny Chevalier <chevalier.ronny@gmail.com>
Date: Sun, 14 May 2017 14:30:40 +0000 (+0200)
Subject: env-util: fix memory leak (#5962)
X-Git-Tag: chiark/234.4-1+devuan1.1+iwj1~132
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=bebfe0e4982c29e97032c1d40155620d37595e77;p=elogind.git

env-util: fix memory leak (#5962)

If cunescape succeeds, but the assignment is not valid, uce is not freed.
---

diff --git a/src/basic/env-util.c b/src/basic/env-util.c
index 1b8a96def..cb73c9caa 100644
--- a/src/basic/env-util.c
+++ b/src/basic/env-util.c
@@ -800,8 +800,10 @@ int deserialize_environment(char ***environment, const char *line) {
         if (r < 0)
                 return r;
 
-        if (!env_assignment_is_valid(uce))
+        if (!env_assignment_is_valid(uce)) {
+                free(uce);
                 return -EINVAL;
+        }
 
         return strv_env_replace(environment, uce);
 }