From: Daniel Martí <mvdan@mvdan.cc>
Date: Wed, 19 Aug 2015 00:53:56 +0000 (-0700)
Subject: Warn about misplaced flattr donation links
X-Git-Tag: 0.5.0~193
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=b9397733c317bb2f17ddf1aa094f172ac270771a;p=fdroidserver.git

Warn about misplaced flattr donation links
---

diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py
index f255b502..189b52ed 100644
--- a/fdroidserver/lint.py
+++ b/fdroidserver/lint.py
@@ -63,6 +63,10 @@ regex_warnings = {
         (re.compile(r'.*github\.com/[^/]+/[^/]+[/]*$'),
          "/issues is missing"),
     ],
+    'Donate': http_warnings + [
+        (re.compile(r'.*flattr\.com'),
+         "Flattr donation methods belong in the FlattrID flag"),
+    ],
     'Changelog': http_warnings + [
     ],
     'License': [
@@ -247,6 +251,8 @@ def main():
             for m, r in regex_warnings[f]:
                 t = metadata.metafieldtype(f)
                 if t == 'string':
+                    if app[f] is None:
+                        continue
                     if m.match(app[f]):
                         warn("%s '%s': %s" % (f, app[f], r))
                 elif t == 'multiline':