From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 2 Oct 2014 12:35:34 +0000 (+0200)
Subject: localectl: always print warnings with log_warning() instead of printf()
X-Git-Tag: v217~371
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=b344bcbbfda8fbe14dadc5aa4b5dfb3ced6d76e2;p=elogind.git

localectl: always print warnings with log_warning() instead of printf()

They really should got to stderr, not stdout.
---

diff --git a/src/locale/localectl.c b/src/locale/localectl.c
index 9325d9af6..3690f9fc8 100644
--- a/src/locale/localectl.c
+++ b/src/locale/localectl.c
@@ -117,13 +117,12 @@ static void print_overriden_variables(void) {
         for (j = 0; j < _VARIABLE_LC_MAX; j++)
                 if (variables[j]) {
                         if (print_warning) {
-                                printf("Warning: Settings on Kernel Command Line override system locale settings in /etc/locale.conf\n");
-                                printf("    Command Line: %s=%s\n", locale_variable_to_string(j), variables[j]);
+                                log_warning("Warning: Settings on kernel command line override system locale settings in /etc/locale.conf.\n"
+                                            "  Command Line: %s=%s\n", locale_variable_to_string(j), variables[j]);
 
                                 print_warning = false;
-                                continue;
-                        }
-                        printf("                  %s=%s\n", locale_variable_to_string(j), variables[j]);
+                        } else
+                                log_warning("                %s=%s\n", locale_variable_to_string(j), variables[j]);
                 }
  finish:
         for (j = 0; j < _VARIABLE_LC_MAX; j++)