From: Hans-Christoph Steiner <hans@eds.org>
Date: Wed, 26 Oct 2016 18:41:37 +0000 (+0200)
Subject: use versionName unmodified as specified
X-Git-Tag: 0.8~149^2~4
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=ab8d51012d0b36b9b927dbd613b5087eeba3452f;p=fdroidserver.git

use versionName unmodified as specified

The versionName is defined as a string or string resource that can be any
arbitrary data.  fdroid should not second guess the developer here, and
should just use the versionName unmodified.  For anything that needs to
compare different versions of apps, versionCode should always be used since
that's what Android uses.

https://developer.android.com/guide/topics/manifest/manifest-element.html#vname
---

diff --git a/fdroidserver/build.py b/fdroidserver/build.py
index daf109dd..37febba9 100644
--- a/fdroidserver/build.py
+++ b/fdroidserver/build.py
@@ -860,14 +860,6 @@ def build_local(app, build, vcs, build_dir, output_dir, srclib_dir, extlib_dir,
     if foundid != app.id:
         raise BuildException("Wrong package ID - build " + foundid + " but expected " + app.id)
 
-    # Some apps (e.g. Timeriffic) have had the bonkers idea of
-    # including the entire changelog in the version number. Remove
-    # it so we can compare. (TODO: might be better to remove it
-    # before we compile, in fact)
-    index = version.find(" //")
-    if index != -1:
-        version = version[:index]
-
     if (version != build.version or
             vercode != build.vercode):
         raise BuildException(("Unexpected version/version code in output;"