From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed, 18 Jan 2017 18:18:38 +0000 (+0000)
Subject: infrastructure: Do not reject commits with no author/committer name
X-Git-Tag: archive/debian/3.6~2
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=ab5a6e7990806975bfd31a47cf61f429eb8914e3;hp=b77bfa84e1dd2f7fe760985a76d7bafcfc463802;p=dgit.git

infrastructure: Do not reject commits with no author/committer name

But still insist on email address and date).

Peter Green reports that eg 71e128629ec786f3 in upstream xen.git is
such a commit (and is accepted by github).

Closes:#851716.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/debian/changelog b/debian/changelog
index c73480b7..b1c7db17 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -11,6 +11,10 @@ dgit (3.6~) unstable; urgency=medium
   Infrastructure:
   * Properly honour NOCOMMITCHECK policy hook exit status.
     Closes:#851800.
+  * Do not reject commits with no author/committer name (but still insist
+    on email address and date).  Peter Green reports that eg
+    71e128629ec786f3 in upstream xen.git is such a commit (and is accepted
+    by github).  Closes:#851716.
 
   Test suite:
   * downstream-gitless: Test import of .dsc from unknown distro.
diff --git a/infra/dgit-repos-server b/infra/dgit-repos-server
index aa6fecd2..6131774e 100755
--- a/infra/dgit-repos-server
+++ b/infra/dgit-repos-server
@@ -897,8 +897,8 @@ sub checks () {
 
     # defend against commits generated by #849041
     if (!($policy & NOCOMMITCHECK)) {
-	my @checks = qw(%an %ae %at
-			%cn %ce %ct);
+	my @checks = qw(%ae %at
+			%ce %ct);
 	my @chk = qw(git log -z);
 	push @chk, '--pretty=tformat:%H%n'.
 	    (join "", map { $_, '%n' } @checks);