From: Daniel Martí <mvdan@mvdan.cc>
Date: Thu, 3 Dec 2015 13:00:47 +0000 (+0100)
Subject: metadata: write strings directly to txt file
X-Git-Tag: 0.6.0~65
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=a9bb5f97130e50a240c0eff5fb95359c0d5e1204;p=fdroidserver.git

metadata: write strings directly to txt file
---

diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py
index f39de762..f66ebc1a 100644
--- a/fdroidserver/metadata.py
+++ b/fdroidserver/metadata.py
@@ -1289,17 +1289,22 @@ def write_txt_metadata(mf, app):
                 continue
 
             t = flagtype(f)
-            out = '    %s=' % f
+            mf.write('    %s=' % f)
             if t == TYPE_STRING:
-                out += v
+                mf.write(v)
             elif t == TYPE_BOOL:
-                out += 'yes'
+                mf.write('yes')
             elif t == TYPE_SCRIPT:
-                out += '&& \\\n        '.join([s.lstrip() for s in v.split('&& ')])
+                first = True
+                for s in v.split(' && '):
+                    if first:
+                        first = False
+                    else:
+                        mf.write(' && \\\n        ')
+                    mf.write(s)
             elif t == TYPE_LIST:
-                out += ','.join(v) if type(v) == list else v
+                mf.write(','.join(v))
 
-            mf.write(out)
             mf.write('\n')
 
     write_plaintext_metadata(mf, app, w_comment, w_field, w_build)