From: Daniel Martí <mvdan@mvdan.cc>
Date: Sun, 1 Jun 2014 13:38:11 +0000 (+0200)
Subject: Don't allow for duplicate build entries
X-Git-Tag: 0.2~51
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=a544907bef2d724be3a591260efbf3087934381a;p=fdroidserver.git

Don't allow for duplicate build entries
---

diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py
index ef302721..4fff0746 100644
--- a/fdroidserver/metadata.py
+++ b/fdroidserver/metadata.py
@@ -649,6 +649,7 @@ def parse_metadata(metafile):
     buildlines = []
     curcomments = []
     curbuild = None
+    vc_seen = {}
 
     c = 0
     for line in metafile:
@@ -719,6 +720,10 @@ def parse_metadata(metafile):
                                             .format(value, linedesc))
                 curbuild['version'] = vv[0]
                 curbuild['vercode'] = vv[1]
+                if curbuild['vercode'] in vc_seen:
+                    raise MetaDataException('Duplicate build recipe found for vercode %s in %s' % (
+                                            curbuild['vercode'], linedesc))
+                vc_seen[curbuild['vercode']] = True
                 buildlines = []
                 mode = 3
             elif fieldtype == 'obsolete':