From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 16 Apr 2018 19:37:12 +0000 (+0200)
Subject: polkit: normalize exit values of polkit_agent_open_if_enabled()
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=a1fa0c718c6120fef15cc7ff872b7e721f5cfbb8;p=elogind.git

polkit: normalize exit values of polkit_agent_open_if_enabled()

It's strange eating up the errors here, hence don't. Let's leave this
to the caller.
---

diff --git a/src/shared/spawn-polkit-agent.h b/src/shared/spawn-polkit-agent.h
index ea72c1281..c4316ea47 100644
--- a/src/shared/spawn-polkit-agent.h
+++ b/src/shared/spawn-polkit-agent.h
@@ -12,17 +12,17 @@
 int polkit_agent_open(void);
 void polkit_agent_close(void);
 
-static inline void polkit_agent_open_if_enabled(
+static inline int polkit_agent_open_if_enabled(
                 BusTransport transport,
                 bool ask_password) {
 
         /* Open the polkit agent as a child process if necessary */
 
         if (transport != BUS_TRANSPORT_LOCAL)
-                return;
+                return 0;
 
         if (!ask_password)
-                return;
+                return 0;
 
-        polkit_agent_open();
+        return polkit_agent_open();
 }