From: Daniel Martí <mvdan@mvdan.cc>
Date: Wed, 5 Aug 2015 17:52:53 +0000 (-0700)
Subject: lint: complain about UCMs that haven't been used
X-Git-Tag: 0.5.0~214
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=9fc583289e8ce86c69a428f97067afac8098d194;p=fdroidserver.git

lint: complain about UCMs that haven't been used

Mainly for MRs from people who don't fill the automatic fields
---

diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py
index 314366e1..678152da 100644
--- a/fdroidserver/lint.py
+++ b/fdroidserver/lint.py
@@ -138,6 +138,8 @@ def main():
     allapps = metadata.read_metadata(xref=False)
     apps = common.read_app_args(args, allapps, False)
 
+    filling_ucms = re.compile('^(Tags.*|RepoManifest.*)')
+
     for appid, app in apps.iteritems():
         if app['Disabled']:
             continue
@@ -171,6 +173,14 @@ def main():
             if app['Web Site'].lower() == app['Source Code'].lower():
                 warn("Website '%s' is just the app's source code link" % app['Web Site'])
 
+        if filling_ucms.match(app['Update Check Mode']):
+            if all(app[f] == metadata.app_defaults[f] for f in [
+                    'Auto Name',
+                    'Current Version',
+                    'Current Version Code',
+                    ]):
+                warn("UCM is set but it looks like checkupdates hasn't been run yet")
+
         # Missing or incorrect categories
         if not app['Categories']:
             warn("Categories are not set")