From: Michal Schmidt <mschmidt@redhat.com>
Date: Mon, 5 Dec 2011 23:47:28 +0000 (+0100)
Subject: unit: garbage collect units with load error
X-Git-Tag: v38~171
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=9a46fc3b9014de1bf0ed1f3004a536b08a19ebb3;p=elogind.git

unit: garbage collect units with load error

Units that failed to load were never cleaned up. It was possible to
reach the 128K limit of units by attempting to load a bunch of nonsense.

Bug observed by Reartes Guillermo in
https://bugzilla.redhat.com/show_bug.cgi?id=680122
---

diff --git a/src/unit.c b/src/unit.c
index 2a549e2f8..018e9861c 100644
--- a/src/unit.c
+++ b/src/unit.c
@@ -858,6 +858,7 @@ fail:
         u->meta.load_state = UNIT_ERROR;
         u->meta.load_error = r;
         unit_add_to_dbus_queue(u);
+        unit_add_to_gc_queue(u);
 
         log_debug("Failed to load configuration for %s: %s", u->meta.id, strerror(-r));