From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 5 Apr 2018 16:00:39 +0000 (+0200)
Subject: path-util: document a few other special cases for last_path_component()
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=97ac04b502a8bbe11b8a58adcecaf7d7bc3f478e;p=elogind.git

path-util: document a few other special cases for last_path_component()
---

diff --git a/src/basic/path-util.c b/src/basic/path-util.c
index 4c5f984bd..addd39373 100644
--- a/src/basic/path-util.c
+++ b/src/basic/path-util.c
@@ -723,16 +723,23 @@ char* dirname_malloc(const char *path) {
 }
 
 const char *last_path_component(const char *path) {
-        /* Finds the last component of the path, preserving the
-         * optional trailing slash that signifies a directory.
+
+        /* Finds the last component of the path, preserving the optional trailing slash that signifies a directory.
+         *
          *    a/b/c → c
          *    a/b/c/ → c/
+         *    x → x
+         *    x/ → x/
+         *    /y → y
+         *    /y/ → y/
          *    / → /
          *    // → /
          *    /foo/a → a
          *    /foo/a/ → a/
-         * This is different than basename, which returns "" when
-         * a trailing slash is present.
+         *
+         *    Also, the empty string is mapped to itself.
+         *
+         * This is different than basename(), which returns "" when a trailing slash is present.
          */
 
         unsigned l, k;
diff --git a/src/test/test-path-util.c b/src/test/test-path-util.c
index 057c06e8c..f7e96283f 100644
--- a/src/test/test-path-util.c
+++ b/src/test/test-path-util.c
@@ -401,6 +401,10 @@ static void test_last_path_component(void) {
         assert_se(streq(last_path_component("/foo/a"), "a"));
         assert_se(streq(last_path_component("/foo/a/"), "a/"));
         assert_se(streq(last_path_component(""), ""));
+        assert_se(streq(last_path_component("a"), "a"));
+        assert_se(streq(last_path_component("a/"), "a/"));
+        assert_se(streq(last_path_component("/a"), "a"));
+        assert_se(streq(last_path_component("/a/"), "a/"));
 }
 
 static void test_filename_is_valid(void) {