From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat, 8 Jul 2017 16:59:55 +0000 (+0100)
Subject: dgit: avoid "Use of uninitialized value $got in concatenation"
X-Git-Tag: archive/debian/3.11~20
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=965e601bb3231f2a3e97d6faf04febc61cec8ba8;p=dgit.git

dgit: avoid "Use of uninitialized value $got in concatenation"

When dgit wanted to report that a file it downloaded had the wrong
checksum, it would instead crash with this message.  This was due to
complete_file_from_dsc's $got (which is relied on by the callers of
$checkhash) being shadowed inside $checkhash.

This is part of #867185/#867185.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/dgit b/dgit
index 6134f5c7..8d7af112 100755
--- a/dgit
+++ b/dgit
@@ -2519,7 +2519,7 @@ sub complete_file_from_dsc ($$;$) {
 	$fi->{Digester}->reset();
 	$fi->{Digester}->addfile(*F);
 	F->error and die $!;
-	my $got = $fi->{Digester}->hexdigest();
+	$got = $fi->{Digester}->hexdigest();
 	return $got eq $fi->{Hash};
     };