From: Marcus Hoffmann <bubuiic@aol.com>
Date: Tue, 12 Sep 2017 23:40:09 +0000 (+0200)
Subject: checkupdates: fix google play check method
X-Git-Tag: 0.9~85^2~1
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=921524081c62d1941da2a0de3c1c837ceffcfc93;p=fdroidserver.git

checkupdates: fix google play check method

This has never worked with python3 and was also not properly adapted to
apps as objects. So we fix both of these issues.
---

diff --git a/fdroidserver/checkupdates.py b/fdroidserver/checkupdates.py
index 098280b2..856a514c 100644
--- a/fdroidserver/checkupdates.py
+++ b/fdroidserver/checkupdates.py
@@ -279,7 +279,7 @@ def check_gplay(app):
     req = urllib.request.Request(url, None, headers)
     try:
         resp = urllib.request.urlopen(req, None, 20)
-        page = resp.read()
+        page = resp.read().decode()
     except urllib.error.HTTPError as e:
         return (None, str(e.code))
     except Exception as e:
@@ -531,7 +531,7 @@ def main():
     apps = common.read_app_args(options.appid, allapps, False)
 
     if options.gplay:
-        for app in apps:
+        for appid, app in apps.items():
             version, reason = check_gplay(app)
             if version is None:
                 if reason == '404':