From: Ciaran Gultnieks <ciaran@ciarang.com>
Date: Thu, 26 Jul 2012 08:16:41 +0000 (+0100)
Subject: Better detection of git-svn find-rev failure
X-Git-Tag: 0.1~798
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=6eb2229a3b0cb1f2b70611e325abe4571c6e6be5;p=fdroidserver.git

Better detection of git-svn find-rev failure
---

diff --git a/fdroidserver/common.py b/fdroidserver/common.py
index 06f1b94f..37caf6fc 100644
--- a/fdroidserver/common.py
+++ b/fdroidserver/common.py
@@ -173,7 +173,7 @@ class vcs_gitsvn(vcs):
             p = subprocess.Popen(['git', 'svn', 'find-rev', 'r' + rev],
                 cwd=self.local, stdout=subprocess.PIPE)
             rev = p.communicate()[0].rstrip()
-            if p.returncode != 0:
+            if p.returncode != 0 or len(rev) == 0:
                 raise VCSException("Failed to get git treeish from svn rev")
             # Check out the appropriate revision...
             if subprocess.call(['git', 'checkout', rev], cwd=self.local) != 0: