From: Daniel Martí <mvdan@mvdan.cc>
Date: Fri, 18 Apr 2014 18:54:44 +0000 (+0200)
Subject: Add summary-related lint warnings
X-Git-Tag: 0.2~118
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=6d8dd4bed29ceb80641e3aeab7f06f968403a021;p=fdroidserver.git

Add summary-related lint warnings
---

diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py
index 13479286..7d36c612 100644
--- a/fdroidserver/lint.py
+++ b/fdroidserver/lint.py
@@ -170,6 +170,18 @@ def main():
             warn("Summary of length %s is over the %i char limit" % (
                 summ_chars, config['char_limits']['Summary']))
 
+        # Redundant summaries
+        summary = app['Summary']
+        name = str(app['Name'] if app['Name'] else app['Auto Name'])
+        if summary and name:
+            summary_l = summary.lower()
+            name_l = name.lower()
+            if summary_l == name_l:
+                warn("Summary '%s' is just the app's name" % summary)
+            elif (summary_l in name_l or name_l in summary_l):
+                pwarn("Summary '%s' probably contains redundant info of app name '%s'" % (
+                    summary, name))
+
         # Invalid lists
         desc_chars = 0
         for line in app['Description']: