From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 6 Nov 2014 19:00:01 +0000 (+0100)
Subject: switch-root: explain why we don't care about base_filesystem_create() failing
X-Git-Tag: v218~518
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=64e18fd626838c3500e28b4dbf86ed62206fff47;p=elogind.git

switch-root: explain why we don't care about base_filesystem_create() failing
---

diff --git a/src/shared/switch-root.c b/src/shared/switch-root.c
index 1a558b897..3adb8463c 100644
--- a/src/shared/switch-root.c
+++ b/src/shared/switch-root.c
@@ -102,6 +102,11 @@ int switch_root(const char *new_root, const char *oldroot, bool detach_oldroot,
                 }
         }
 
+        /* Do not fail, if base_filesystem_create() fails. Not all
+         * switch roots are like base_filesystem_create() wants them
+         * to look like. They might even boot, if they are RO and
+         * don't have the FS layout. Just ignore the error and
+         * switch_root() nevertheless. */
         (void) base_filesystem_create(new_root);
 
         if (chdir(new_root) < 0) {