From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Tue, 2 Oct 2012 12:42:10 +0000 (+0200)
Subject: shared: fail mkdir_p if the target exists and is not a directory
X-Git-Tag: v194~19
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=5b585b5380e8e9b7975905989042743911d699e2;p=elogind.git

shared: fail mkdir_p if the target exists and is not a directory

This makes mkdir_p actually behave like mkdir -p.
---

diff --git a/src/shared/mkdir.c b/src/shared/mkdir.c
index d654b632e..0e51b64f6 100644
--- a/src/shared/mkdir.c
+++ b/src/shared/mkdir.c
@@ -115,6 +115,13 @@ int mkdir_parents_label(const char *path, mode_t mode) {
         return makedir_parents(path, mode, true);
 }
 
+static int is_dir(const char* path) {
+        struct stat st;
+        if (stat(path, &st) < 0)
+                return -errno;
+        return S_ISDIR(st.st_mode);
+}
+
 static int makedir_p(const char *path, mode_t mode, bool apply) {
         int r;
 
@@ -124,7 +131,8 @@ static int makedir_p(const char *path, mode_t mode, bool apply) {
         if (r < 0)
                 return r;
 
-        if (label_mkdir(path, mode, apply) < 0 && errno != EEXIST)
+        r = label_mkdir(path, mode, apply);
+        if (r < 0 && (errno != EEXIST || is_dir(path) <= 0))
                 return -errno;
 
         return 0;