From: Daniel Martí <mvdan@mvdan.cc>
Date: Sun, 22 Dec 2013 20:39:39 +0000 (+0100)
Subject: Use OptionError exceptions
X-Git-Tag: 0.1~86
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=588277479b4bddec655479ddb13f5732c3a95ca7;p=fdroidserver.git

Use OptionError exceptions
---

diff --git a/fdroidserver/build.py b/fdroidserver/build.py
index 184584e7..0bc49874 100644
--- a/fdroidserver/build.py
+++ b/fdroidserver/build.py
@@ -28,7 +28,7 @@ import traceback
 import time
 import json
 from ConfigParser import ConfigParser
-from optparse import OptionParser
+from optparse import OptionParser, OptionError
 
 import common, metadata
 from common import BuildException, VCSException, FDroidPopen
@@ -820,8 +820,7 @@ def parse_commandline():
         options.stop = True
 
     if options.force and not options.test:
-        print "Force is only allowed in test mode"
-        sys.exit(1)
+        raise OptionError("Force is only allowed in test mode", "force")
 
     return options, args
 
@@ -834,16 +833,14 @@ def main():
 
     options, args = parse_commandline()
     if not args and not options.all:
-        print "If you really want to build all the apps, use --all"
-        sys.exit(1)
+        raise OptionError("If you really want to build all the apps, use --all", "all")
 
     config = common.read_config(options)
 
     if config['build_server_always']:
         options.server = True
     if options.resetserver and not options.server:
-        print "Using --resetserver without --server makes no sense"
-        sys.exit(1)
+        raise OptionError("Using --resetserver without --server makes no sense", "resetserver")
 
     log_dir = 'logs'
     if not os.path.isdir(log_dir):
diff --git a/fdroidserver/install.py b/fdroidserver/install.py
index a133ede5..b61cfcb4 100644
--- a/fdroidserver/install.py
+++ b/fdroidserver/install.py
@@ -21,7 +21,7 @@
 import sys
 import os
 import glob
-from optparse import OptionParser
+from optparse import OptionParser, OptionError
 
 import common
 from common import FDroidPopen
@@ -49,15 +49,14 @@ def main():
     (options, args) = parser.parse_args()
 
     if not args and not options.all:
-        print "If you really want to install all the signed apps, use --all"
-        sys.exit(1)
+        raise OptionError("If you really want to install all the signed apps, use --all", "all")
 
     config = common.read_config(options)
 
     output_dir = 'repo'
     if not os.path.isdir(output_dir):
         print "No signed output directory - nothing to do"
-        sys.exit(1)
+        sys.exit(0)
 
     if args: