From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 11 Jan 2018 12:09:30 +0000 (+0100)
Subject: log: minor modernizations to log_received_signal()
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=36e85d4409a757442a6043b79815504234183143;p=elogind.git

log: minor modernizations to log_received_signal()
---

diff --git a/src/basic/log.c b/src/basic/log.c
index 5bbf65a4a..1f91dc4ba 100644
--- a/src/basic/log.c
+++ b/src/basic/log.c
@@ -1247,10 +1247,12 @@ DEFINE_STRING_TABLE_LOOKUP(log_target, LogTarget);
 
 #if 0 /// UNNEEDED by elogind
 void log_received_signal(int level, const struct signalfd_siginfo *si) {
-        if (si->ssi_pid > 0) {
+        assert(si);
+
+        if (pid_is_valid(si->ssi_pid)) {
                 _cleanup_free_ char *p = NULL;
 
-                get_process_comm(si->ssi_pid, &p);
+                (void) get_process_comm(si->ssi_pid, &p);
 
                 log_full(level,
                          "Received SIG%s from PID %"PRIu32" (%s).",