From: Daniel Martí <mvdan@mvdan.cc>
Date: Mon, 22 Dec 2014 17:18:07 +0000 (+0100)
Subject: lint: warn (pedantic) about potentially dangerous auto updates
X-Git-Tag: 0.3.0~9
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=3662dfd1452457e6a60f5b329bcf7b14dc0ec3c2;p=fdroidserver.git

lint: warn (pedantic) about potentially dangerous auto updates
---

diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py
index 2a028b72..f6deefbb 100644
--- a/fdroidserver/lint.py
+++ b/fdroidserver/lint.py
@@ -183,6 +183,12 @@ def main():
             pwarn("Last used commit '%s' looks like a tag, but Update Check Mode is '%s'" % (
                 curbuild['commit'], app['Update Check Mode']))
 
+        # Dangerous auto updates
+        if curbuild and app['Auto Update Mode'] != 'None':
+            for flag in ['target', 'srclibs', 'scanignore']:
+                if curbuild[flag]:
+                    pwarn("Auto Update Mode is enabled but '%s' is manually set at '%s'" % (flag, curbuild[flag]))
+
         # Summary size limit
         summ_chars = len(app['Summary'])
         if summ_chars > config['char_limits']['Summary']: