From: Daniel Martí <mvdan@mvdan.cc>
Date: Sat, 12 Sep 2015 06:17:46 +0000 (-0700)
Subject: checkupdates: Avoid variable/string names as CV
X-Git-Tag: 0.5.0~103
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=3638acddc4ed51dbd7563fd4038f37df3eb75829;p=fdroidserver.git

checkupdates: Avoid variable/string names as CV
---

diff --git a/fdroidserver/checkupdates.py b/fdroidserver/checkupdates.py
index f06e35a7..78648410 100644
--- a/fdroidserver/checkupdates.py
+++ b/fdroidserver/checkupdates.py
@@ -433,6 +433,12 @@ def checkupdates_app(app, first=True):
         vercode = str(eval(op))
         logging.debug("Applied vercode operation: %s -> %s" % (oldvercode, vercode))
 
+    if version and any(version.startswith(s) for s in [
+            '${',  # Gradle variable names
+            '@string/',  # Strings we could not resolve
+            ]):
+        version = "Unknown"
+
     updating = False
     if version is None:
         logmsg = "...{0} : {1}".format(app['id'], msg)