From: Daniel Martí <mvdan@mvdan.cc>
Date: Thu, 26 Jun 2014 10:39:42 +0000 (+0200)
Subject: Simplify check_metadata
X-Git-Tag: 0.2~5
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=33ed7f077d16bd77a1c16fa6fecbad05b0b7c3c4;p=fdroidserver.git

Simplify check_metadata
---

diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py
index 9870207f..3e6ec83e 100644
--- a/fdroidserver/metadata.py
+++ b/fdroidserver/metadata.py
@@ -218,12 +218,10 @@ valuetypes = {
 def check_metadata(info):
     for v in valuetypes:
         for field in v.fields:
-            if field in info:
-                v.check(info[field], info['id'])
+            v.check(info[field], info['id'])
         for build in info['builds']:
             for attr in v.attrs:
-                if build[attr]:
-                    v.check(build[attr], info['id'])
+                v.check(build[attr], info['id'])
 
 
 # Formatter for descriptions. Create an instance, and call parseline() with