From: Michael Pöhn <michael.poehn@fsfe.org>
Date: Tue, 30 May 2017 12:53:54 +0000 (+0200)
Subject: proper error message when publishing with the same app in repo and unsigned
X-Git-Tag: 0.9~86^2
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=328c1ad0c7385d3a74063fc9e87fb643caf6960b;p=fdroidserver.git

proper error message when publishing with the same app in repo and unsigned
---

diff --git a/fdroidserver/publish.py b/fdroidserver/publish.py
index 1ca89e15..ad200906 100644
--- a/fdroidserver/publish.py
+++ b/fdroidserver/publish.py
@@ -194,6 +194,13 @@ def main():
                 if p.returncode != 0:
                     raise BuildException("Failed to generate key")
 
+            signed_apk_path = os.path.join(output_dir, apkfilename)
+            if os.path.exists(signed_apk_path):
+                raise BuildException("Refusing to sign '{0}' file exists in both "
+                                     "{1} and {2} folder.".format(apkfilename,
+                                                                  unsigned_dir,
+                                                                  output_dir))
+
             # Sign the application...
             p = FDroidPopen([config['jarsigner'], '-keystore', config['keystore'],
                              '-storepass:env', 'FDROID_KEY_STORE_PASS',